add support for k8s jobs #4019
Merged
add support for k8s jobs #4019
+192
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemacysts
reviewed
Mar 13, 2025
| def format_kubernetes_job( | ||
| self, | ||
| job_label: str, | ||
| deadline_seconds: int = 3600, |
There was a problem hiding this comment.
just curious: we'd talked about limiting the max uptime for the sandbox jobs - given that this doesn't do any limiting, I assume that we'll have the thresholds set in the new remote-run command? or do we want to add a max uptime check/clamp here?
There was a problem hiding this comment.
yes, I was planning to clamp the value in the API view
nemacysts
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One first portion of #3986, with a couple of minor improvements, as I didn't want to bunch everything together as it'd be a pretty large change to review.
Next I'll do the API endpoints, and I'll finish with the client side bits.