remove vestigial remote-run implementation #4018
Merged
+18
−1,344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piax93
force-pushed
the
u/mpiano/SEC-19862_clean_old
branch
from
1183c05 to
e1c9bc1
Compare
nemacysts
approved these changes
Mar 12, 2025
There was a problem hiding this comment.
ty - we started going down the road of deleting a bunch of mesos code in a past unhack, but we ran out of time to completely excise things and haven't come back around to finish :)
There was a problem hiding this comment.
i look forward to the day we finish removing the mesos code :dream:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the aim of soon going to integrate bit by bit the POC code implemented in #3986, I'd like to start from ripping off the legacy remote-run code which has been dead since we moved away from Mesos. It technically also seems to support running stuff ssh-ing to adhoc instances, but I have not found any place where this would be used, as currently we prefer the pattern "Tron ssh executor + paasta local-run / spark-run".
There would be so many more crufty Mesos thing to get rid of, but I limited myself to
log_task_lifecycle_events, since that was using some of the methods provided by the remote-run module, but it's absolutely not referenced anywhere in our environment. It's not even linked by the paasta-tools debian package.