Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YS-304] refactor: 공고 상세 조회 시 반환값으로 alarmAgree 필드 추가 #94

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

chock-cho
Copy link
Member

@chock-cho chock-cho commented Feb 12, 2025

💡 작업 내용

  • 프론트엔드의 요청으로 기존 공고 상세 조회 시 누락되었던 alarmAgree 필드값을 추가하여 반환합니다.

✅ 셀프 체크리스트

  • PR 제목을 형식에 맞게 작성했나요?
  • 브랜치 전략에 맞는 브랜치에 PR을 올리고 있나요?
  • 테스트는 잘 통과했나요?
  • 빌드에 성공했나요?
  • 본인을 assign 해주세요.
  • 해당 PR에 맞는 label을 붙여주세요.

🙋🏻‍ 확인해주세요

  • 관련된 Discussion 등이 있다면 첨부해주세요
    단순한 필드값 추가이기 때문에 유연하게 핫픽스 처리하겠습니다.

🔗 Jira 티켓


https://yappsocks.atlassian.net/browse/YS-304

Summary by CodeRabbit

  • 새로운 기능
    • 실험 게시물 상세 정보 응답에 사용자의 알림 수신 동의 여부를 나타내는 새로운 필드가 추가되었습니다.
    • 이 개선을 통해 게시물 관련 알림 설정 상태를 보다 명확하게 확인할 수 있습니다.
    • 업데이트된 응답 정보는 사용자 맞춤 설정에 대한 이해도를 높여 사용자 경험을 향상시킵니다.

@chock-cho chock-cho added the ♻️ REFACTORING 리팩토링 label Feb 12, 2025
@chock-cho chock-cho self-assigned this Feb 12, 2025
Copy link

coderabbitai bot commented Feb 12, 2025

Walkthrough

이 PR은 실험 게시글 세부 정보를 제공하는 데이터 클래스와 관련 메서드에 새로운 alarmAgree: Boolean 속성을 추가합니다.
GetExperimentPostDetailUseCaseExperimentPostDetail 클래스와 해당 확장 함수, 그리고 응답 DTO인 ExperimentPostDetailResponse와 매핑 함수에 변경이 이루어졌습니다.
이 변경은 알림 동의 여부를 포함하여 데이터의 상세 정보를 확장하는 내용입니다.

Changes

파일 변경 내용
src/.../usecase/experiment/GetExperimentPostDetailUseCase.kt ExperimentPostDetail 데이터 클래스에 alarmAgree: Boolean 속성을 추가하고, toExperimentPostDetail 확장 함수에서 이를 할당하도록 업데이트
src/.../api/dto/response/experiment/ExperimentPostDetailResponse.kt ExperimentPostDetailResponsealarmAgree: Boolean 속성을 추가하고, 기존 isAuthor 뒤에 콤마를 추가하여 구조 변경
src/.../api/mapper/ExperimentPostMapper.kt toGetExperimentPostDetailResponse 함수에서 응답 생성 시 alarmAgree 필드를 포함하도록 수정

Sequence Diagram(s)

sequenceDiagram
    participant C as 클라이언트
    participant API as API 레이어
    participant UC as UseCase
    participant Mapper as 매퍼
    participant Resp as 응답 DTO

    C->>API: 실험 게시글 상세 정보 요청
    API->>UC: GetExperimentPostDetailUseCase 호출
    UC->>Mapper: ExperimentPostDetail 생성 (alarmAgree 포함)
    Mapper->>Resp: ExperimentPostDetailResponse 생성 (alarmAgree 포함)
    Resp->>C: 응답 반환
Loading

Poem

귀여운 토끼의 기쁜 노래
새 알림 속삭임, alarmAgree 빛나네
코드 숲에서 한 걸음씩
속성 하나에 마음을 담아
토끼 발자국처럼 남는 변화의 향연!
🐰🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fbc6cc5 and 65d90be.

📒 Files selected for processing (3)
  • src/main/kotlin/com/dobby/backend/application/usecase/experiment/GetExperimentPostDetailUseCase.kt (2 hunks)
  • src/main/kotlin/com/dobby/backend/presentation/api/dto/response/experiment/ExperimentPostDetailResponse.kt (1 hunks)
  • src/main/kotlin/com/dobby/backend/presentation/api/mapper/ExperimentPostMapper.kt (1 hunks)
🔇 Additional comments (3)
src/main/kotlin/com/dobby/backend/presentation/api/dto/response/experiment/ExperimentPostDetailResponse.kt (1)

51-54: 알림 동의 필드가 적절하게 추가되었습니다!

Schema 설명이 명확하고 Boolean 타입이 적절하게 사용되었습니다.

src/main/kotlin/com/dobby/backend/application/usecase/experiment/GetExperimentPostDetailUseCase.kt (1)

41-42: UseCase에 알림 동의 필드가 올바르게 통합되었습니다!

ExperimentPostDetail 데이터 클래스와 매핑 함수에 alarmAgree 필드가 적절하게 추가되었습니다.

src/main/kotlin/com/dobby/backend/presentation/api/mapper/ExperimentPostMapper.kt (1)

179-180: 매퍼에서 알림 동의 필드가 정확하게 매핑되었습니다!

응답 DTO로의 매핑이 올바르게 구현되어 있습니다.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@chock-cho chock-cho added the 🔥 HOTFIX 핫픽스 label Feb 12, 2025
@chock-cho chock-cho merged commit 6df515f into dev Feb 12, 2025
3 checks passed
@chock-cho chock-cho deleted the refact/YS-304 branch February 12, 2025 16:24
@chock-cho chock-cho changed the title [YS-304] refactor: 공고 상세 조회 시, 반환값으로 alarmAgree 필드 추가 [YS-304] refactor: 공고 상세 조회 시 반환값으로 alarmAgree 필드 추가 Feb 12, 2025
@chock-cho chock-cho added 🐛 BUG 버그 and removed ♻️ REFACTORING 리팩토링 labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 BUG 버그 🔥 HOTFIX 핫픽스
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant