docs(BUILD): add -j $(nproc) #5288
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves build times.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5288 +/- ##
=======================================
Coverage 78.1% 78.2%
=======================================
Files 790 790
Lines 67638 67638
Branches 8164 8160 -4
=======================================
+ Hits 52859 52868 +9
+ Misses 14779 14770 -9 see 3 files with indirect coverage changes |
legleux
reviewed
Feb 13, 2025
| @@ -283,7 +283,7 @@ It fixes some source files to add missing `#include`s. | |||
| Single-config generators: | |||
|
|
|||
| ``` | |||
| cmake --build . | |||
| cmake --build . -j $(nproc) | |||
There was a problem hiding this comment.
Seems fine.
This sets the max of the underlying build tool. Unix Makefile defaults to 1 but will Ninja max your system out.
legleux
approved these changes
Feb 13, 2025
bthomee
added
the
Trivial
tequdev
reviewed
Feb 13, 2025
| @@ -283,7 +283,7 @@ It fixes some source files to add missing `#include`s. | |||
| Single-config generators: | |||
|
|
|||
| ``` | |||
| cmake --build . | |||
| cmake --build . -j $(nproc) | |||
There was a problem hiding this comment.
nproc is not available on macos.
Since BUILD.md mentions building on Linux/Windows/Mac, it would be helpful to include the commands for each.
I usually use sysctl -n hw.logicalcpu on macos.
There was a problem hiding this comment.
Yes, I forgot to mention that also.
brew install coreutils will get you nproc instead of that malarky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This improves build times. I think the time is cut to about 1/6 for me - a big difference. I am not sure if there is a situation when it should not be used.
Context of Change
BUILD instructions
Type of Change
.gitignore, formatting, dropping support for older tooling)