Properly detect NVM path on macOS using homebrew

[gravityrail]

Description

When attempting to build the plugin on macOS, I encountered the following error:

(path to plugins)/gutenberg (master)$ ./bin/setup-local-env.sh
./bin/install-node-nvm.sh: line 13: /Users/me/.nvm/nvm.sh: No such file or directory

By detecting homebrew and using the --prefix command, we can find the true path to nvm.sh on macOS systems.

How Has This Been Tested?

By running ./bin/setup-local-env.sh and seeing that it completes without error. Hopefully my else clause allows this to work properly on Linux machines, which I have NOT tested.

I also tried with nvm uninstalled, ensuring that brew was used to install nvm on systems with homebrew available.

Types of changes

Check for brew command and use to find nvm.sh, and to install nvm if necessary.

Checklist:

• My code is tested.
• My code follows the WordPress code style.
• My code has proper inline documentation.

[pento]

NVM explicitly doesn't support installing with homebrew, so we definitely don't want to be using homebrew to install NVM.

I'd be okay with the Load NVM logic to look something like:

• Check if $NVM_DIR is not null.
  • Check if $NVM_DIR/nvm.sh exists.
    • If it exists, load it.
    • If it doesn't exist, check if command_exists brew is true.
      • If brew exists, check if $(brew --prefix nvm)/nvm.sh exists.
        • If it exists:
          • Load it.
          • echo -e $(warning_message "NVM is installed using homebrew, which is not supported by the NVM maintainers. If you run into problems with NVM, it's recommended that you remove it using the following command:" )
          • echo -e $(warning_message "$(action_format "brew uninstall nvm")" )
          • echo -e $(warning_message "After that, re-run the setup script to install NVM correctly." )

[gravityrail]

That seems reasonable. I didn't realise nvm wasn't supported via homebrew.

I think rather than warning people who use nvm via homebrew, let's just silently try to use it if it's there and the regular way of running nvm fails. The reason being, if they have installed it via homebrew and aren't having problems (as I have, with zero issues) then I don't see a need to rattle their cage over this issue.

I also pushed up a change to my logic so rather than first checking for homebrew, it first checks for the standard location of nvm.sh, inside the .nvm dir, before trying homebrew as a fallback.

[pento]

I'm not particularly fussed about whether to include the warning about using homebrew, let's see if we get more reports as we get more people using the script.

[pento]

Use command_exists here. eg:

elif command_exists "brew"; then

[pento]

(Side note: command_exists is a helper function we use: https://github.com/WordPress/gutenberg/blob/master/bin/includes.sh#L123-L134)

[gravityrail]

Cool, fixed

[pento]

Any particular reason for deleting this comment?

[gravityrail]

User error ;) fixed.

[pento]

Need to check that the file exists before including it: it could've been installed with some other package manager.

[gravityrail]

Good catch.

[pento]

👍🏻