Update handling of empty template description cell #56394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskoster
added
[Type] Enhancement
|
Size Change: +254 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
jameskoster
commented
Nov 21, 2023
| ) : ( | ||
| <> | ||
| <Text variant="muted" aria-hidden="true"> | ||
| { __( '—' ) } |
There was a problem hiding this comment.
Unsure if this needs to be translatable 🤔
There was a problem hiding this comment.
It's not a translatable string in core, so I think you can use the same decision here. I suggest using the same character as is used in core, for consistency: —
joedolson
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Update visible 'no data' character to not be translatable & use same character as core. Otherwise, I think this is fine. It maybe should be abstracted out for better reusability; as data views are developed more broadly, there will be a common need for rendering empty cells, and each may need a different text string.
I agree, but I don't know that it needs to prohibit this PR unless it is easy to do. Any thoughts @ntsekouras? |
|
I'll bow to @ntsekouras as to whether this should be abstracted now or handle it later. From a functional perspective, I think this is fine, however. |
joedolson
approved these changes
Nov 22, 2023
|
Do you think we should close this since @jameskoster added similar changes here, that's going to land soon? I'm saying this just because there are subtle differences about not using Regarding the abstraction, let's do it separately since there are some nuances on how to know if the used component eventually renders something or not. I've added a task in the main tracking issue. |
|
Yes, good point, let's close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Display a dash (–) when the template has no description. Include a more verbose "No description." message for screen readers.
Why?
An empty cell can give the impression that the data failed to load.
How?
Copies the same technique used to handle empty cells in wp-admin:
–witharia-hidden="true".Testing Instructions