Fix review findings

Wargus · Mar 1, 2024 · 4a4bb6f · 4a4bb6f
1 parent 02eabf8
commit 4a4bb6f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/sound/sound_server.cpp b/src/sound/sound_server.cpp
@@ -231,7 +231,7 @@ static bool External_Volume(int volume, int oldVolume) {
 	return false;
 }
 #else
-static bool External_Play(const std::string &file) {
+static bool External_Play(const std::string & /*file*/) {
 	return false;
 }
 static bool External_IsPlaying() {
@@ -240,7 +240,7 @@ static bool External_IsPlaying() {
 static bool External_Stop() {
 	return false;
 }
-static bool External_Volume(int volume, int oldVolume) {
+static bool External_Volume(int /*volume*/, int /*oldVolume*/) {
 	return false;
 }
 #endif

diff --git a/src/ui/script_ui.cpp b/src/ui/script_ui.cpp
@@ -1140,6 +1140,10 @@ static int CclCopyButtonsForUnitType(lua_State *l)
 	const std::string_view fromName = LuaToString(l, 1);
 	const std::string_view toName = LuaToString(l, 2);
 
+	// Check types exist
+	UnitTypeByIdent(fromName);
+	UnitTypeByIdent(toName);
+
 	for (auto &btn : UnitButtonTable) {
 		if (btn->UnitMask.find(fromName) != std::string::npos) {
 			btn->UnitMask += toName;

diff --git a/src/video/shaders.cpp b/src/video/shaders.cpp
@@ -257,7 +257,6 @@ static GLint FrameCount;
 static GLint OutputSize;
 static GLint TextureSize;
 static GLint InputSize;
-// static GLint VertexCoord;
 static GLint TexCoord;
 // caches that don't change for a window size
 static int RecacheCount = 0; // rechache multiple times - races!