Use strlcpy instead of strncpy

[yuzibo]

On Debian, it will report as below:
native/syscalls.c:864:22: error: passing argument 2 of ‘strncpy’ from incompatible pointer type [-Wincompatible-pointer-types]
864 | strncpy(buf, &address_->sun_path, 108);
| ^~~~~~~~~~~~~~~~~~~
| |
| char (*)[108]

[yuzibo]

See build log

[yuzibo]

hmm, maybe we still use strncpy here? or could you help me to have a look at these tests failed?

[remram44]

I'm traveling now but I'm happy to fix the build when I'm back, don't worry about it.

[yuzibo]

I'm traveling now but I'm happy to fix the build when I'm back, don't worry about it.

Okay, thank you. Please enjoy your traveling.:)

[remram44]

I can confirm that removing the & fixes the build on gcc 14. I don't see a problem with the use of strncpy so I am going to stick with it as it's more standard.

[remram44]

Fixed by dc7e12b.

[yuzibo]

Thanks for your quickly fix.

But I have one concern here, can we ensure address_->sun_path is less than 108? or is address_->sun_path one valid string with \0?

[remram44]

Yes, the struct is:

struct sockaddr_un {
    sa_family_t sun_family;     /* AF_UNIX */
    char        sun_path[108];  /* Pathname */
};