Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(REACH-800): Update CI to run on Node version 20 #617

Merged
merged 1 commit into from
Oct 3, 2023
Merged

feat(REACH-800): Update CI to run on Node version 20 #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ jobs:
strategy:
matrix:
node_version:
- 14 # end of life 2023-04-30
- 16 # end of life 2023-09-11
- 18 # end of life 2025-04-30
- 20 # end of life 2025-04-30
name: build-lint-test - node ${{ matrix.node_version }}
steps:
- name: Check out Git repository
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Get yarn cache
uses: actions/cache@v2
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Get yarn cache
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Get yarn cache
uses: actions/cache@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/visual.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v3
with:
node-version: 16
node-version: 20

- name: Get yarn cache
uses: actions/cache@v2
Expand Down
2 changes: 1 addition & 1 deletion packages/embed/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ You can find examples for specific use-cases in our demos:

Requirements:

- node >= 14 (for node v12 use [v1.38.0](https://www.npmjs.com/package/@typeform/embed/v/1.38.0))
- node >= 16
- yarn

Install dependencies:
Expand Down
2 changes: 1 addition & 1 deletion packages/embed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@
"coverage": "jest --coverage",
"cy:open": "yarn cypress open",
"cy:open:vrt": "yarn cypress open --env testType=visual",
"cy:open:func": "yarn cy:open -c integrationFolder=./e2e/spec/functional/",
"cy:open:func": "yarn cy:open -c e2e.specPattern=./e2e/spec/functional/",
"cy:functional": "yarn cypress run --spec e2e/spec/functional/**/* --headless",
"cy:visual": "yarn cypress run --spec e2e/spec/visual/**/* --env testType=visual",
"test:functional": "start-server-and-test demo 9090 cy:functional",
Expand Down