Fix ASAN: Destructors of base classes must be virtual

TileDB-Inc · Dec 19, 2024 · 0a97612 · 0a97612
1 parent d391375
commit 0a97612
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/tiledb/sm/query/readers/result_tile.h b/tiledb/sm/query/readers/result_tile.h
@@ -466,7 +466,7 @@ class ResultTile {
   DISABLE_COPY_AND_COPY_ASSIGN(ResultTile);
   DISABLE_MOVE_AND_MOVE_ASSIGN(ResultTile);
 
-  /** Default destructor. */
+  /** Destructor needs to be virtual, this is a base class. */
   virtual ~ResultTile();
 
   /* ********************************* */
@@ -931,6 +931,9 @@ class ResultTileWithBitmap : public ResultTile {
   DISABLE_COPY_AND_COPY_ASSIGN(ResultTileWithBitmap);
   DISABLE_MOVE_AND_MOVE_ASSIGN(ResultTileWithBitmap);
 
+  /** Default destructor needs to be virtual, this is a base class. */
+  virtual ~ResultTileWithBitmap() = default;
+
  public:
   /* ********************************* */
   /*          PUBLIC METHODS           */