More tests for index page #14
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
|
@catcatchong The functional testing is still failed, please fix it before requesting another review. |
thislight
requested changes
Jun 24, 2022
| beforeEach(() => { | ||
| cy.resetLogin(); | ||
| cy.login("TEST_USER_1"); | ||
| cy.visit("/"); |
There was a problem hiding this comment.
Maybe we should wait for the page loading after visiting.
| @@ -72,6 +72,7 @@ const UserInfoAvatarButton: Component = () => {//头像组件 | |||
| return ( | |||
| <> | |||
| <IconButton | |||
| id="user-info-avatar-button" | |||
There was a problem hiding this comment.
I can accept using id for testing, but it's better to use aria- tags to identify the elements.
I found a related issue from testing-library/react-testing-library: testing-library/react-testing-library#16.
| @@ -101,7 +102,7 @@ const UserInfoAvatarButton: Component = () => {//头像组件 | |||
| </CardContent > | |||
| <Divider /> | |||
| <CardActions sx={{ justifyContent: "end" }}> | |||
| <Button sx={{padding: "8px"}} color="error" variant="text" size="small" onClick={userSignOut}> | |||
| <Button id="sign-out-button" sx={{padding: "8px"}} color="error" variant="text" size="small" onClick={userSignOut}> | |||
There was a problem hiding this comment.
Same as L75 in the incoming change: it's better to use aria- tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to add more tests for the index page.