Skip to content

Commit

Permalink
Add reference to angular#1158 'Proposal'
Browse files Browse the repository at this point in the history
I wish I had read this prior to attempting to migrate.  It may just be that now that I have stumbled through the migration changes the "Proposal" makes good sense but it seems like a resource that would help others.  Much of the added goodness provided by these API changes need to be more fully explained and I think the proposal does a very good job in doing that, plus the comments section make a very good addition.  

I especially appreciated David's opening remark  "Breaking changes are not taken lightly. If we're going to change something, we're going to make it worth your while. Trust me, these new features are well worth it."  However with only the above migration doc to follow, I was cursing some unnamed person or persons long and hard over the past several days.   

I consider myself a skilled novice in all this RxJS-NgRx, like the majority of the folks who would be attempting this migration, and my feedback is that this was far from trivial search and replace.  The end result was much cleaner and I can say that you all have delivered on David's promise, but any additional documentation to assist is going to be very much appreciated.
  • Loading branch information
TheBolmanator authored Oct 14, 2017
1 parent 845fcd0 commit 997b2f7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions docs/version-4-upgrade.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

AngularFire2 4.0 is a refactor of the AngularFire2 package which implements
@NgModule, simplifies authentication, and better supports Angular 4.
For background on the motivations and implementation of these change you may refer to the for these API changes [`Proposal`](https://github.com/angular/angularfire2/issues/1158).

### Removing `AngularFire` for Modularity

Expand Down

0 comments on commit 997b2f7

Please sign in to comment.