Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗️ Dry run: add redis streams support #1

Merged
merged 4 commits into from
May 19, 2020

Conversation

Terkwood
Copy link
Owner

@Terkwood Terkwood commented May 16, 2020

Description

Test run at solving redis-rs#162. Merges https://github.com/grippy/redis-streams-rs into redis-rs.

We're mainly opening this PR within a forked repo so that we can easily view the changes over the web. We plan to eventually raise a PR against the main redis-rs repo, once this work looks reasonably complete.

If anyone feels like providing feedback at this stage, you are encouraged to do so!

Tasks

  • provide cargo feature for streams
  • carry over the integration test from redis-streams-rs, using REDISRS_SERVER_TYPE correctly
  • pass REDISRS_SERVER_TYPE=unix cargo test --all-features -- --skip test_cluster
  • pass REDISRS_SERVER_TYPE=tcp RUST_TEST_THREADS=1 cargo test --all-features -- --nocapture --skip test_cluster
  • pass cargo test --doc
  • position these changes logically w.r.t. the existing code base
  • transfer all commands
  • transfer all stream types
  • satisfy all doc lints
  • make a final pass on docs for commands and make sure they contain info from redis docs
  • make a final pass on docs for types and make sure they contain info from redis docs
  • update README

@Terkwood Terkwood changed the title Dry run: redis streams Dry run: add redis streams support May 16, 2020
@Terkwood Terkwood added documentation Improvements or additions to documentation enhancement New feature or request help wanted Extra attention is needed labels May 16, 2020
@Terkwood Terkwood changed the title Dry run: add redis streams support 🏗️ Dry run: add redis streams support May 16, 2020
@Terkwood Terkwood removed the help wanted Extra attention is needed label May 17, 2020
@Terkwood Terkwood marked this pull request as ready for review May 18, 2020 20:14
@Terkwood Terkwood force-pushed the feature/redis-streams-commands branch from 47c1298 to a5458b8 Compare May 18, 2020 21:05
@Terkwood Terkwood closed this May 18, 2020
@Terkwood
Copy link
Owner Author

This looks like it's ready to be raised against the main repo.

@Terkwood
Copy link
Owner Author

Terkwood commented May 18, 2020

See redis-rs#319.

@Terkwood Terkwood reopened this May 19, 2020
@Terkwood Terkwood merged commit 8f7886e into master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant