Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework gateway redis strategy #420

Merged
merged 31 commits into from
Oct 23, 2020
Merged

Rework gateway redis strategy #420

merged 31 commits into from
Oct 23, 2020

Conversation

Terkwood
Copy link
Owner

@Terkwood Terkwood commented Oct 23, 2020 •
edited
Loading

Focus

Uses XREADGROUP for stream reads.

  • rip out entry ID repo in gateway
  • update redis-streams to 0.4.0 and remove redis dep (XReadEntryId only in this crate, now 🥳)
  • fix gateway redis-streams dep to use rev, not branch
  • update gateway redis dep

Advances #310, #302

Misc

Refactors module structure and renames as appropriate. Touches up browser readme docs. Removes dead docker-helper scripts. Alters the browser default port for local gateway. Maps a high port number from host to container gateway to support local dev.

@Terkwood Terkwood added the tech-debt Lib upgrades, Carryover from prior decisions, &c label Oct 23, 2020
@Terkwood Terkwood marked this pull request as ready for review October 23, 2020 20:17
@Terkwood Terkwood merged commit a5b10d1 into unstable Oct 23, 2020
@Terkwood Terkwood deleted the fix/gateway-redis branch October 23, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
tech-debt Lib upgrades, Carryover from prior decisions, &c
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Terkwood