Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚮destroy all entry ID repos #310

Closed
5 tasks done
Terkwood opened this issue Jun 2, 2020 · 0 comments · Fixed by #423
Closed
5 tasks done

🚮destroy all entry ID repos #310

Terkwood opened this issue Jun 2, 2020 · 0 comments · Fixed by #423
Labels
tech-debt Lib upgrades, Carryover from prior decisions, &c

Comments

@Terkwood
Copy link
Owner

Terkwood commented Jun 2, 2020

Goal

Just use XREADGROUP (redis-rs xread fn with a group option) and request IDs of ">". This will obviate the need to maintain entry ID repositories entirely. You must XACK after processing each request.

Each service should be responsible for creating a uniquely named group associated with each stream being processed. Each group only needs a single consumer. In this way, multiple services can potentially read from the same stream without consuming each other's messages.

See the examples in redis-rs/redis-rs#319.

Services to update

  • micro-judge
  • micro-changelog
  • micro-game-lobby
  • botlink?
  • gateway
@Terkwood Terkwood added the tech-debt Lib upgrades, Carryover from prior decisions, &c label Jun 2, 2020
@Terkwood Terkwood pinned this issue Jun 2, 2020
@Terkwood Terkwood unpinned this issue Sep 11, 2020
@Terkwood Terkwood changed the title rust services: destroy all entry ID repos 🚮destroy all entry ID repos Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-debt Lib upgrades, Carryover from prior decisions, &c
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant