Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(loading): added mode to loading directive + service. #85

Merged
merged 7 commits into from
Sep 30, 2016

Conversation

emoralesb05
Copy link
Contributor

@emoralesb05 emoralesb05 commented Sep 17, 2016

Description

Added mode to loading component so it can be created with either LoadingMode.Determinate or LoadingMode.Indeterminate.
#80

What's included?

  • Added enum for LoadingMode.Determinate and LoadingMode.Indeterminate.
  • Added loadingMode input to TdLoadingDirective which accepts either LoadingMode or 'determinate'|'indeterminate'.
  • Added setValue(name: string, value: number): boolean method to TdLoadingService which is only successful if loading is set to LoadingMode.Determinate or 'determinate'.
  • Added reset flag in TdLoadingComponent so its refreshed before removing it from DOM. (else the animation going from the previous value to 0 would happen when the component is reattached again)
  • Kept protractor hack intact so it does not timeout when loading mask is used on 'indeterminate' mode. (md-progress-circle setInterval() usage affects protractor since it does not let it sync)
  • Updated docs/demos with mode usage.

Test Steps

Screenshots or link to CodePen/Plunker/JSfiddle

loading-det-indet1

@kyleledbetter kyleledbetter merged commit 2e83b20 into develop Sep 30, 2016
@emoralesb05 emoralesb05 deleted the feature/loading-det branch September 30, 2016 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants