feature(loading): added mode to loading directive + service. #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
mode
to loading component so it can be created with eitherLoadingMode.Determinate
orLoadingMode.Indeterminate
.#80
What's included?
LoadingMode.Determinate
andLoadingMode.Indeterminate
.loadingMode
input toTdLoadingDirective
which accepts eitherLoadingMode
or'determinate'|'indeterminate'
.setValue(name: string, value: number): boolean
method toTdLoadingService
which is only successful if loading is set toLoadingMode.Determinate
or'determinate'
.reset
flag inTdLoadingComponent
so its refreshed before removing it from DOM. (else the animation going from the previous value to 0 would happen when the component is reattached again)protractor
hack intact so it does not timeout when loading mask is used on'indeterminate'
mode. (md-progress-circle
setInterval() usage affects protractor since it does not let it sync)docs
/demos
withmode
usage.Test Steps
ng serve
Screenshots or link to CodePen/Plunker/JSfiddle