-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for opds-pse for undownloaded chapters #1278
base: master
Are you sure you want to change the base?
Conversation
…aded Add OPDS page streaming for undownloaded chapters
@zeedif your input is probably welcomed here |
…aded Add [D] prefix to chapter title when downloaded
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/ChapterDownloadHelper.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/manga/impl/chapter/ChapterForDownload.kt
Outdated
Show resolved
Hide resolved
server/src/main/kotlin/suwayomi/tachidesk/opds/controller/OpdsV1Controller.kt
Show resolved
Hide resolved
@ShirishSaxena Thank you for the contribution. While the Downloaded Chapter Emojis
Undownloaded Chapter Emojis
|
I find the support for reading manga without downloading useful, as it saves the hassle of going to the web UI and downloading them manually. However, I wonder if it’s possible to mark a chapter as 'read' when accessed via OPDS. For example, triggering the 'read' status either after downloading its CBZ through OPDS or when reaching the last image via OPDS-PSE streaming. |
@zeedif , I didn’t give much thought to the "[D]" identifier, and yeah, you’re right. OPDS-PSE.-.Chapter.Progress.mp4 |
The implementation seems fine to me, though requiring a chapter "detail feed" adds unnecessary friction to the OPDS navigation flow. While I understand the current limitation of slow pageCount checks on paginated feeds, a longer-term solution would be to pre-fetch pageCount once during library addition or chapter discovery (e.g., background tasks when manga is added/updated). This would eliminate the need for the detail feed entirely. |
Pre-fetching page count is not possible, since that requires a request to the source and there are manga that have hundreds of chapters. Its not viable. |
…PDS chapters and manga
Relates to #1265.
Changes
Notes
-I tried making this call for all chapters in the paginated manga feed, but even with just 20 entries per page, it felt pretty slow. Plus, OPDS clients don’t really seem to support seamless chapter reading (KOReader definitely doesn’t). So instead, I added a separate “detail” page for each chapter when the page count is missing. This way, we can read undownloaded chapters, and if we revisit the chapter later, it won’t redirect us to the detail page again.
FYI: I use KOReader to read manga, so this entire modification is based on that.
KOReader screen recording for this change
Screenrecording_20250222_131141.mp4
KoReader with "D" as prefix for downloaded chapter
Chapter 126 for Slime's manga was downloaded in a folder.KOreader.mp4