-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Downloaded chapters with pageCount 0 not listed in OPDS feed and cause errors when accessed #1265
Comments
@zeedif this issue was automatically closed because:
|
the
the only way I see that a chapter gets marked as downloaded without having a valid |
What I find curious is that it wasn't specific chapters; I downloaded about 11 series, and of those, two entire series have their chapters marked as downloaded, but none of them have a pageCount greater than 0. So, perhaps it's related to how updatePageCount is called when series are downloaded from Browse > Source > {my_favorite_source} > {manga_name} > Download > Unread or from Library > {manga name} > Download > Unread, since that's how I did those downloads. |
have you checked what the server logged for these chapter downloads?
the clients have no impact on how the server handles the download, they just call the api and tell the server what should get downloaded |
I just checked the logs to see what was happening, and those two specific series weren’t showing up in the logs. I went to check their folders and found they only had the comicinfo.xml files. So, I went to the WebUI, deleted them, and tried downloading one chapter again. When I saw the download finished instantly, I decided to remove them from my favorites, went to the Browse tab, navigated to my source, searched for the manga again, re-added it, and re-downloaded it. Now it seems to be downloading correctly. The only thing I can think of is that there might have been a broken reference between the source and the manga. I should also mention that I imported my reading progress and favorited manga using the backup file generated by TachiJ2K from the Backup menu > Create backup. |
sounds like
was the problem with the chapters incorrectly getting marked as downloaded (fixed by #1268) maybe the backup included outdated urls for the manga, but then I would expect the request for the chapters pages to fail instead of returning an empty list, but could also be that the source doesn't handles this properly? |
The latest preview build includes the fix, so if it is determined to be that issue, then it shouldn't happen anymore. |
we probably should add a migration to fix chapters which are in such a state, just to be sure (forgot to add it in #1268) |
If we click download and it detects a cbz, will it check if it has pages or not? |
it checks if the first page exists |
@zeedif in the latest preview, any downloads with this issue will be marked as not download when you update to it. |
Device information
Steps to reproduce
Expected behavior
Actual behavior
Context from Discord discussion:
pageCount
isn't populated during download, only via API/GraphQL callspageCount
Affected workflow:
This creates contradiction between:
The text was updated successfully, but these errors were encountered: