Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing and kwarg removals #102

Merged
merged 38 commits into from
Dec 23, 2024
Merged

typing and kwarg removals #102

merged 38 commits into from
Dec 23, 2024

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Nov 27, 2024

Changes are typing

plus:

Added mypy bash files for local testing

Added time_left_float which does not take or return None

configs are now a SpallocConfig object rather than a dict

  • all values typed

Job init has all params specified.
note: a None param is used to say do not use the value from config just use None

  • default "USE_CONFIG"
  • support methods to pick between param (if not default) and config
  • all values are named params
  • except args which can be 0 to 3 values

update method string now formatted
includes:
SpiNNakerManchester/SpiNNFrontEndCommon#1247
SpiNNakerManchester/sPyNNaker#1510 (from T_pacman)

@Christian-B Christian-B merged commit e27aef5 into master Dec 23, 2024
10 checks passed
@Christian-B Christian-B deleted the t_spalloc branch February 19, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants