type unit tests #590
Merged
type unit tests #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ApplicationVertex changed type of spliiter to just AbstractSplitterCommon without the Self
This was needed as "Self" takes on the Type of any SuperClass
And most super classes do that have a specif splitter.
Tags.get_reverse_ip_tags_for_vertex return changed from Iterable to List as it is always a List
Chip tag_ids returned type changed to more specific OrderedSet
Simply/ correct test as nothing was ever logged
PACMAN/unittests/model_tests/partitioner_splitters_tests/splitter_slice_legacy_test.py
Line 37 in 5232679