Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calculate system cores before getMachine can be called #547

Merged
merged 7 commits into from
Mar 12, 2024
Merged

Conversation

Christian-B
Copy link
Member

@Christian-B Christian-B commented Mar 11, 2024

These PRs calculate the resources needed for monitor cores before a run is stated and a machine in requested.

This has 2 functions.

  1. The ChipCounter is more accurate and will work for Spin2

  2. Allow users to request n_cores in setup
    To convert that to n Chips and N boards we need to know how many cores per chips will be taken by the monitor cores.

Therefor we now support the idea of adding Sample (never to be placed) monitor vertices.

We track the monitor vertices so can calculate sdram when we have all the required data

As the SDRAM may depend on the runtime the calculation of the SDRAM cost of these vertices is delayed until needed.
Only core count is needed for get_machine
ChipCounter is only used during simulator run.

Must be done together with:
SpiNNakerManchester/SpiNNFrontEndCommon#1164

allows:
SpiNNakerManchester/MarkovChainMonteCarlo#63

tested by http://apollo.cs.man.ac.uk:8080/blue/organizations/jenkins/Integration%20Tests/detail/monitor_size/1/pipeline/

@coveralls
Copy link

coveralls commented Mar 11, 2024

Coverage Status

coverage: 86.186% (+0.04%) from 86.142%
when pulling 912177b on monitor_size
into f689c54 on master.

@Christian-B Christian-B marked this pull request as ready for review March 12, 2024 10:39
@rowleya rowleya merged commit 07ec798 into master Mar 12, 2024
9 checks passed
@rowleya rowleya deleted the monitor_size branch March 12, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants