More spalloc rest calls #1222
More spalloc rest calls #1222
Conversation
| @@ -0,0 +1,238 @@ | |||
| /* | |||
| * Copyright (c) 2022 The University of Manchester | |||
There was a problem hiding this comment.
That file was renamed, but I can change the date if desired... edge case!
| @QueryParam(SIZE) int size, @Suspended AsyncResponse response); | ||
|
|
||
| /** | ||
| * Clear routes, reset counters and install counting filters needed. |
There was a problem hiding this comment.
Comment suggests this is just clearing out old routing tables preparing new ones which is what the method name suggests.
There was a problem hiding this comment.
I guess "reset" might be better...
| * Class used to manage a download. Every instance <em>must only</em> ever | ||
| * be used from one thread. | ||
| * | ||
| * @author Donal Fellows |
There was a problem hiding this comment.
why is brand new code tagged Donal?
| @@ -0,0 +1,19 @@ | |||
| /* | |||
| * Copyright (c) 2018 The University of Manchester | |||
| @@ -0,0 +1,19 @@ | |||
| /* | |||
| * Copyright (c) 2018 The University of Manchester | |||
| @@ -2629,6 +2639,22 @@ public void loadSystemRouterTables(CoreSubsets monitorCores) | |||
| .loadSystemRouterTable(monitorCores); | |||
| } | |||
|
|
|||
| @Override | |||
| public void prepareRouters(Map<Integer, DiagnosticFilter> customFilters) | |||
There was a problem hiding this comment.
Keep this the same as the python.
Both in names and it Filters are passed in or created here.
| throws IOException, InterruptedException, | ||
| StorageException, URISyntaxException, SpinnmanException { | ||
| super(machine, db); | ||
| txrx = getTransceiver(); |
There was a problem hiding this comment.
Why a call a get method as the last call?
There was a problem hiding this comment.
This keeps the transceiver for use in the function. Note the get is a get on the super. In Java, you can't do this before calling the super constructor
| + "FROM app_id "; | ||
| "SELECT app_id FROM info"; | ||
|
|
||
| /** Get he machine dimensions. */ |
Push more through REST calls in spalloc. This avoids sending lots of UDP packets over TCP when writing data, reading data, fast writing data, fast reading data and setting up routers (the other bit that was slow).
In order to make use of the new calls, also needs:
Tested by: