Change type of date/time fields from 'string' to 'DateTimeOffset'

Add unit test for creating a ticket with DueAt setting Add check for CreatedAt, UpdatedAt to ticket creation test
Speedygeek · Sep 11, 2014 · cde6aa9 · cde6aa9
1 parent 4481d8b
commit cde6aa9
Show file tree

Hide file tree

Showing 34 changed files with 226 additions and 84 deletions.
diff --git a/Tests/TicketTests.cs b/Tests/TicketTests.cs
@@ -220,6 +220,9 @@ public void CanCreateUpdateAndDeleteTicket()
             Assert.NotNull(res);
             Assert.Greater(res.Id, 0);
 
+            Assert.AreEqual(res.CreatedAt, res.UpdatedAt);
+            Assert.LessOrEqual(res.CreatedAt - DateTimeOffset.UtcNow, TimeSpan.FromMinutes (1.0));
+
             res.Status = TicketStatus.Solved;
             res.AssigneeId = Settings.UserId;
 
@@ -234,6 +237,7 @@ public void CanCreateUpdateAndDeleteTicket()
             Assert.NotNull(updateResponse);
             Assert.AreEqual(updateResponse.Audit.Events.First().Body, body);
             Assert.Greater(updateResponse.Ticket.CollaboratorIds.Count, 0);
+            Assert.GreaterOrEqual(updateResponse.Ticket.UpdatedAt, updateResponse.Ticket.CreatedAt);
 
             Assert.True(api.Tickets.Delete(res.Id.Value));
         }
@@ -264,6 +268,28 @@ public void CanCreateTicketWithRequester()
             Assert.True(api.Tickets.Delete(res.Id.Value));
         }
 
+        [Test]
+        public void CanCreateTicketWithDueDate()
+        {
+            var dueAt = DateTimeOffset.UtcNow;
+
+            var ticket = new Ticket()
+            {
+                Subject = "ticket with due date",
+                Comment = new Comment() { Body = "test comment" },
+                Type = "task",
+                Priority = TicketPriorities.Normal,
+                DueAt = DateTimeOffset.UtcNow
+            };
+
+            var res = api.Tickets.CreateTicket(ticket).Ticket;
+
+            Assert.NotNull(res);
+            Assert.AreEqual(dueAt.ToString(), res.DueAt.ToString());
+
+            Assert.True(api.Tickets.Delete(res.Id.Value));
+        }
+
         [Test]
         public void CanCreateTicketWithTicketFormId()
         {

diff --git a/ZendeskApi_v2/Models/AccountsAndActivities/Activity.cs b/ZendeskApi_v2/Models/AccountsAndActivities/Activity.cs
@@ -1,7 +1,9 @@
 // JSON C# Class Generator
 // http://at-my-window.blogspot.com/?page=json-class-generator
 
+using System;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 
 
 namespace ZendeskApi_v2.Models.AccountsAndActivities
@@ -29,9 +31,11 @@ public class Activity
         public ZendeskApi_v2.Models.Users.User Actor { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
     }
 }
diff --git a/ZendeskApi_v2/Models/Categories/Category.cs b/ZendeskApi_v2/Models/Categories/Category.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.Categories
@@ -24,9 +25,11 @@ public class Category
         public int Position { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
     }
 }
diff --git a/ZendeskApi_v2/Models/CustomRoles/CustomRole.cs b/ZendeskApi_v2/Models/CustomRoles/CustomRole.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.CustomRoles
@@ -21,10 +22,12 @@ public class CustomRole
         public string Description { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
 
         [JsonProperty("configuration")]
         public Configuration Configuration { get; set; }

diff --git a/ZendeskApi_v2/Models/Forums/Forum.cs b/ZendeskApi_v2/Models/Forums/Forum.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.Forums
@@ -43,9 +44,11 @@ public class Forum
         public string Access { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
     }
 }
diff --git a/ZendeskApi_v2/Models/Forums/ForumSubscription.cs b/ZendeskApi_v2/Models/Forums/ForumSubscription.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.Forums
@@ -22,6 +23,7 @@ public class ForumSubscription
         public long? UserId { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
     }
 }
diff --git a/ZendeskApi_v2/Models/Groups/Group.cs b/ZendeskApi_v2/Models/Groups/Group.cs
@@ -1,4 +1,6 @@
+using System;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 
 namespace ZendeskApi_v2.Models.Groups
 {
@@ -18,9 +20,11 @@ public class Group
         public bool Deleted { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
     }
-}
+}
diff --git a/ZendeskApi_v2/Models/Groups/GroupMembership.cs b/ZendeskApi_v2/Models/Groups/GroupMembership.cs
@@ -1,4 +1,6 @@
+using System;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 
 namespace ZendeskApi_v2.Models.Groups
 {
@@ -21,9 +23,11 @@ public class GroupMembership
         public bool Default { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
     }
-}
+}
diff --git a/ZendeskApi_v2/Models/Locales/Locale.cs b/ZendeskApi_v2/Models/Locales/Locale.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.Locales
@@ -25,9 +26,11 @@ public class Locale
         public string Name { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
     }
 }
diff --git a/ZendeskApi_v2/Models/Macros/Macro.cs b/ZendeskApi_v2/Models/Macros/Macro.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.Macros
@@ -24,10 +25,12 @@ public class Macro
         public bool? Active { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("restriction")]
         public Restriction Restriction { get; set; }

diff --git a/ZendeskApi_v2/Models/Organizations/Organization.cs b/ZendeskApi_v2/Models/Organizations/Organization.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.Organizations
@@ -25,10 +26,12 @@ public class Organization
         public string Name { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
 
         [JsonProperty("domain_names")]
         public IList<object> DomainNames { get; set; }

diff --git a/ZendeskApi_v2/Models/Requests/Request.cs b/ZendeskApi_v2/Models/Requests/Request.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 using ZendeskApi_v2.Models.Shared;
 using ZendeskApi_v2.Models.Tickets;
@@ -39,10 +40,12 @@ public class Request
         public IList<CustomField> CustomFields { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
 
         /// <summary>
         /// This is used for updates only

diff --git a/ZendeskApi_v2/Models/SatisfactionRatings/SatisfactionRating.cs b/ZendeskApi_v2/Models/SatisfactionRatings/SatisfactionRating.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.Satisfaction
@@ -34,10 +35,12 @@ public class SatisfactionRating
         public string Score { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("comment")]
         public string Comment { get; set; }

diff --git a/ZendeskApi_v2/Models/Search/Result.cs b/ZendeskApi_v2/Models/Search/Result.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 using ZendeskApi_v2.Models.Shared;
 using ZendeskApi_v2.Models.Tickets;
@@ -66,10 +67,12 @@ public class Result
         public int? CommentsCount { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("updated_at")]
-        public string UpdatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? UpdatedAt { get; set; }
 
         [JsonProperty("id")]
         public int Id { get; set; }

diff --git a/ZendeskApi_v2/Models/Shared/Audit.cs b/ZendeskApi_v2/Models/Shared/Audit.cs
@@ -1,5 +1,7 @@
+using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 
 namespace ZendeskApi_v2.Models.Shared
 {
@@ -12,7 +14,8 @@ public  class Audit
         public string TicketId { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
 
         [JsonProperty("author_id")]
         public long AuthorId { get; set; }
@@ -26,4 +29,4 @@ public  class Audit
         [JsonProperty("events")]
         public IList<Event> Events { get; set; }
     }
-}
+}
diff --git a/ZendeskApi_v2/Models/SharingAgreements/SharingAgreement.cs b/ZendeskApi_v2/Models/SharingAgreements/SharingAgreement.cs
@@ -4,6 +4,7 @@
 using System;
 using System.Collections.Generic;
 using Newtonsoft.Json;
+using Newtonsoft.Json.Converters;
 using Newtonsoft.Json.Linq;
 
 namespace ZendeskApi_v2.Models.SharingAgreements
@@ -27,6 +28,7 @@ public class SharingAgreement
         public string Status { get; set; }
 
         [JsonProperty("created_at")]
-        public string CreatedAt { get; set; }
+        [JsonConverter(typeof(IsoDateTimeConverter))]
+        public DateTimeOffset? CreatedAt { get; set; }
     }
 }