Update RSPEC metadata + rules in SonarWay #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
andrei-epure-sonarsource
requested changes
Aug 10, 2018
| @@ -10240,7 +10240,7 @@ | |||
| <value>switch can contain a default clause for various reasons: to handle unexpected values, to show that all the cases were properly considered.</value> | |||
There was a problem hiding this comment.
I think this should be updated as well (locally, for me, it's updated)
| @@ -3262,7 +3262,7 @@ | |||
| <value>Attackers can use widely-available tools to view cookies and read any sensitive information they may contain. Even if the information is encoded in a way that is not human-readable, certain techniques could determine which encoding is being used, then decode the information.</value> | |||
| </data> | |||
| <data name="S2255_IsActivatedByDefault" xml:space="preserve"> | |||
| <value>False</value> | |||
| <value>True</value> | |||
| </data> | |||
| <data name="S2255_Remediation" xml:space="preserve"> | |||
| <value>Constant/Issue</value> | |||
There was a problem hiding this comment.
For <data name="S4144_Description" xml:space="preserve">, locally I have
When two methods have the same implementation, either it was a mistake - something else was intended - or the duplication was intentional, but may be confusing to maintainers. In the latter case, one implementation should invoke the other.
andrei-epure-sonarsource
approved these changes
Aug 13, 2018
|
Update: the changes which I reported in my previous comments must be reviewed, because they may imply a change in behavior which may have to be implemented before updating the RSPEC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1663
Fix #1662
Fix #1661
Fix #1660
Fix #1658