fix(predictive-search): remove font from image #1595
+0
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a unnecessary font-family property on the search image with the content of `'object-fit: container'`, which is invalid at first and second we don’t really need font-family on the search image explicit.
ghost
added
the
ludoboludo
approved these changes
Jun 6, 2022
There was a problem hiding this comment.
Hello @Maybach91, thanks for looking Dawn and ways to make it better 🙂
In this case I think we had this declaration as a work around to support the css property object-fit in older browsers. Though it's only used in this instance 🤔
So I think we can actually get rid of it. Thanks for taking care of it.
Looks like most browser do support the property and don't need a work around: screenshot
|
Any plan to merge this @ludoboludo @KaichenWang @martinamarien ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary:
There was an unnecessary
font-familyproperty on the search image with the content of'object-fit: container', which is invalid at first and second we don’t really need font-family on the search image explicit.Why are these changes introduced?
clean code
Testing steps/scenarios
Checklist