feature(core): Add scoop-shim helper #3438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ash258
reviewed
May 6, 2019
| @@ -427,8 +428,11 @@ function shim($path, $global, $name, $arg) { | |||
| } | |||
|
|
|||
| if($path -match '\.(exe|com)$') { | |||
| if(!(Test-HelperInstalled -Helper Shim)) { | |||
| scoop install 'main/scoop-shim' | |||
There was a problem hiding this comment.
Manifest is missing binary. Is it intentional?
There was a problem hiding this comment.
Yes, what would be the purpose of shimming the shim? 😄
There was a problem hiding this comment.
You can use it then from anywhere and shim anything. Nice for users who want to shim custom executables.
Small workaround for #3303
There was a problem hiding this comment.
I would like to avoid recursions 😁
It could just be copied from ~/scoop/apps/scoop-shim/current/shim.exe
|
The robocopy tests fail because they require a shimmed file. |
|
Closing in favour of #4736 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the extracted Shim.exe
Related: #3066