Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-install.ps1): Auto uninstall previous failed installation #3281

Merged
merged 2 commits into from
Nov 8, 2021
Merged

fix(scoop-install.ps1): Auto uninstall previous failed installation #3281

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4aaba1f
auto uninstall
niheaven Mar 29, 2019
d913508
Some tweaks
niheaven Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libexec/scoop-install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ function is_installed($app, $global) {

$version = @(versions $app $global)[-1]
if (!(install_info $app $version $global)) {
error "It looks like a previous installation of $app failed.`nRun 'scoop uninstall $app$(gf $global)' before retrying the install."
warn "Purging previous failed installation of $app."
& "$PSScriptRoot\scoop-uninstall.ps1" $app$(gf $global)
return $false
}
warn "'$app' ($version) is already installed.`nUse 'scoop update $app$(gf $global)' to install a new version."
return $true
Expand Down Expand Up @@ -94,7 +96,8 @@ if ($specific_versions.length -gt 0) {
$specific_versions_paths = $specific_versions | ForEach-Object {
$app, $bucket, $version = parse_app $_
if (installed_manifest $app $version) {
abort "'$app' ($version) is already installed.`nUse 'scoop update $app$global_flag' to install a new version."
warn "'$app' ($version) is already installed.`nUse 'scoop update $app$(if ($global) { " --global" })' to install a new version."
continue
}

generate_user_manifest $app $bucket $version
Expand Down