Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice: Fix pre_install script bug #9491

Closed
wants to merge 5 commits into from
Closed

libreoffice: Fix pre_install script bug #9491

wants to merge 5 commits into from

Conversation

StarsbySea
Copy link
Contributor

@StarsbySea StarsbySea commented Oct 16, 2022

Fix tiny logical bug in pre_install caused by ScoopInstaller/Scoop#5116 which changed the config name from MSIEXTRACT_USE_LESSMSI to use_lessmsi

Closes #8920

Copy link
Member

@tech189 tech189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! I updated the description to explain the fix a bit more and made a suggestion. I don't think this PR fixes #8920 though, that issue has no problem with running the pre_install script.

bucket/libreoffice.json Outdated Show resolved Hide resolved
@StarsbySea
Copy link
Contributor Author

You are right about the code suggestion, I tested it locally and it passed. But there are a few more issues I would like to add.

  1. Regarding the LibreOffice shortcuts error #8920 issue, I think the cause should be due to the update upstream of scoop, which causes get_config MSIEXTRACT_USE_LESSMSI $false to always return false, even though use_lessmsi has been set to true, and I think this is causing the problem. Maybe we should migrate all the MSIEXTRACT_USE_LESSMSI fields in the codebase to use_lessmsi?
  2. specifying $default with get-config does not cause a new configuration to be created, it just changes the default value returned if the value is taken as null.

I have made some code changes, will you take another look?

@StarsbySea
Copy link
Contributor Author

StarsbySea commented Oct 16, 2022

Image1
Image2
Image3

I think those picture says something haha

@StarsbySea
Copy link
Contributor Author

Solve in #9493

@StarsbySea StarsbySea closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LibreOffice shortcuts error
2 participants