Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue #1608 sdk generation #1641

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

martin-trajanovski
Copy link
Collaborator

Description

This PR aims to fix the know issue with the typescript-fetch sdk generation

Motivation

#1608

Fixes

Changes:

  • changes are in the sdk generation pipeline where we needed some additional parameters

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@martin-trajanovski martin-trajanovski self-assigned this Jan 20, 2025
@martin-trajanovski martin-trajanovski added bug Something isn't working DCS DAPHNE Contribution to SciCat labels Jan 20, 2025
@martin-trajanovski martin-trajanovski linked an issue Jan 20, 2025 that may be closed by this pull request
@martin-trajanovski martin-trajanovski merged commit ca918de into master Jan 21, 2025
13 checks passed
@martin-trajanovski martin-trajanovski deleted the issue-1608-fix-sdk-generation branch January 21, 2025 07:52
Junjiequan pushed a commit that referenced this pull request Jan 22, 2025
* fix: issue #1608 sdk generation

* use the configuration json files instead of directly passing the config properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DCS DAPHNE Contribution to SciCat
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate identifier 'id' in job schema
2 participants