Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proposal count endpoint #1626

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

martin-trajanovski
Copy link
Collaborator

@martin-trajanovski martin-trajanovski commented Jan 16, 2025

Description

Added the count endpoint for the proposals.

Motivation

There was no count endpoint for the proposals and we needed it in the frontend

Changes:

  • changes are only in the proposals controller and service

Tests included

  • Included for each change/fix?
  • Passing?

Documentation

  • swagger documentation updated (required for API changes)
  • official documentation updated

official documentation info

@martin-trajanovski martin-trajanovski self-assigned this Jan 16, 2025
@martin-trajanovski martin-trajanovski added feature New feature DCS DAPHNE Contribution to SciCat labels Jan 16, 2025
@Junjiequan Junjiequan force-pushed the proposals-count-endpoint branch from f089461 to e2a19a0 Compare January 17, 2025 12:11
@martin-trajanovski martin-trajanovski merged commit ad3c129 into master Jan 17, 2025
13 checks passed
@martin-trajanovski martin-trajanovski deleted the proposals-count-endpoint branch January 17, 2025 13:43
Junjiequan pushed a commit that referenced this pull request Jan 22, 2025
* feat: add proposal count endpoint

* remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCS DAPHNE Contribution to SciCat feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants