Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-release): remove python-pydantic-v1 generator and publish typescript-fetch sdk #1598

Merged
merged 1 commit into from
Jan 6, 2025
Merged

chore(sdk-release): remove python-pydantic-v1 generator and publish typescript-fetch sdk #1598

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .github/openapi/python-pydantic-v1-config.json
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions .github/workflows/release-and-publish-sdk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:
- start-backend-export-swagger
strategy:
matrix:
generator: [python, python-pydantic-v1, typescript-angular]
generator: [python, typescript-angular, typescript-fetch]

steps:
- name: Checkout repository
Expand All @@ -154,7 +154,7 @@ jobs:
-o ./sdk/${{ matrix.generator }} $(
if [ "${{ matrix.generator }}" == "typescript-angular" ] || [ "${{ matrix.generator }}" == "typescript-fetch" ]; then
echo "--additional-properties=npmVersion=${{ needs.build-release.outputs.new_tag}}";
elif [ "${{ matrix.generator }}" == "python" ] || [ "${{ matrix.generator }}" == "python-pydantic-v1" ]; then
elif [ "${{ matrix.generator }}" == "python" ]; then
echo "--additional-properties=packageVersion=${{ needs.build-release.outputs.new_tag}}";
fi
)
Expand Down Expand Up @@ -208,10 +208,10 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
sdk_type: [python, python-pydantic-v1]
sdk_type: [python]
environment:
name: ${{ matrix.sdk_type }}-sdk-package
url: ${{ matrix.sdk_type == 'python' && 'https://pypi.org/project/scicat-sdk-py' || 'https://pypi.org/project/scicat-sdk-pydantic' }}
url: "https://pypi.org/project/scicat-sdk-py"
permissions:
id-token: write

Expand Down
8 changes: 3 additions & 5 deletions .github/workflows/upload-sdk-artifact.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:

env:
NODE_VERSION: 20.x
SDK_VERSION: latest
SDK_VERSION: 0.0.1
nitrosx marked this conversation as resolved.
Show resolved Hide resolved

jobs:
start-backend-and-upload-swagger-schema:
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:
- start-backend-and-upload-swagger-schema
strategy:
matrix:
generator: [python, typescript-angular, python-pydantic-v1]
generator: [python, typescript-angular, typescript-fetch]

steps:
- name: Checkout repository
Expand All @@ -67,12 +67,10 @@ jobs:
config-file: .github/openapi/${{ matrix.generator }}-config.json
command-args: |
-o ./sdk/${{ matrix.generator }} $(
if [ "${{ matrix.generator }}" == "typescript-angular" ]; then
if [ "${{ matrix.generator }}" == "typescript-angular" ] || [ "${{ matrix.generator }}" == "typescript-fetch" ]; then
echo "--additional-properties=npmVersion=${{env.SDK_VERSION}}";
elif [ "${{ matrix.generator }}" == "python" ]; then
echo "--additional-properties=packageVersion=${{env.SDK_VERSION}}";
elif [ "${{ matrix.generator }}" == "python-pydantic-v1" ]; then
echo "--additional-properties=packageVersion=${{env.SDK_VERSION}}";
fi
)

Expand Down
Loading