test: fix pep8 complaint #5922
Closed
test: fix pep8 complaint #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pep8 complaint about over-indentation in test_multidomain.py file. I guess this is only happening in RHEL8 and Debian because the tool was forked to pycodestyle, only it is being updated and pycodestyle isn't available for those distributions from the package manager. Signed-off-by: Iker Pedrosa <[email protected]>
|
@sidecontrol can you review this PR? It solves our current problems with the python code style tool and I don't know if you already solved them. |
danlavu
approved these changes
Dec 16, 2021
|
@sidecontrol can you set the accepted label? |
|
ACK for the patch. But why newer |
I think it's because the tool was modified after its name was changed. I've found PyCQA/pycodestyle#912 that changes the implementation of the visual indentation checks. This change only applies for tags 2.X, which belong to pycodestyle (tags 1.X are for pep8). But I'm not completely sure about what it does apart from specifying some special treatment for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix pep8 complaint about over-indentation in test_multidomain.py file. I
guess this is only happening in RHEL8 and Debian because the tool was
forked to pycodestyle, only it is being updated and pycodestyle isn't
available for those distributions from the package manager.