Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add property initializers #8846

Merged
merged 111 commits into from
Jun 21, 2024
Merged
Show file tree
Hide file tree
Changes from 107 commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
cd31931
feat: add property initializers
pskelin Nov 29, 2023
b80218f
chore: test
pskelin Apr 25, 2024
3da70de
chore: more components
pskelin Apr 25, 2024
9661a85
chore: add more components
pskelin Apr 25, 2024
98aa525
chore: more components
pskelin Apr 25, 2024
1732874
chore: few fiori components
Apr 25, 2024
1fc397f
chore: fix tests
pskelin Apr 26, 2024
7c11a49
chore: add check for missing type in decorator
pskelin Apr 26, 2024
f600e0f
chore: add more components
pskelin Apr 26, 2024
d6d832b
chore: few fiori components
Apr 26, 2024
257e667
chore: fiori fixes
Apr 26, 2024
da6aedf
chore: more components
pskelin Apr 26, 2024
caf98ab
chore: fix sidenavigation
Apr 26, 2024
dc9e62a
chore: add more components
pskelin Apr 26, 2024
693afd9
chore: list and list items
Apr 26, 2024
19ed3c6
chore: more components
pskelin Apr 26, 2024
cf91276
chore: input tests
Apr 26, 2024
76a8edc
chore: fix test
pskelin Apr 26, 2024
c258b8c
chore: fiori components
Apr 29, 2024
4ea56eb
chore: toolbar, tree
Apr 29, 2024
abe5573
chore: title,text,togglebutton
Apr 29, 2024
a2f9057
chore: fix attribute removal for undefined
pskelin Apr 29, 2024
9226546
chore: update lockfile chromedriver (#8837)
pskelin Apr 25, 2024
412d554
refactor(theming): remove Belize theme (#8519)
nnaydenow Apr 25, 2024
a3df694
fix(ui5-dialog): state icon no longer shrinks when title is too long …
dimovpetar Apr 25, 2024
1f96354
refactor(ui5-wizard): rename event parameter (#8845)
hristop Apr 26, 2024
bbe18e7
refactor(ui5-segmented-button-item): implement segmented button item …
tsanislavgatev Apr 26, 2024
da0a6f0
docs(ui5-upload-collection-item): improve uploadState property descri…
dimovpetar Apr 26, 2024
dfd483f
refactor(ui5-toast): replace `show` method with `open` property (#8855)
MapTo0 Apr 26, 2024
1d939b1
refactor: rename ValueState values (#8864)
ilhan007 Apr 27, 2024
a37f72c
docs: fix SegmentedButton multiple selection sample (#8869)
ilhan007 Apr 27, 2024
4420234
chore: add missing properties to ui5-segmented-button-item (#8870)
nnaydenow Apr 29, 2024
31125ef
chore: toast
Apr 29, 2024
52c9615
Merge remote-tracking branch 'origin' into prop-initializer
Apr 29, 2024
252299f
chore: more components
pskelin Apr 29, 2024
b1978a9
chore: more components
pskelin Apr 30, 2024
8b8a51f
Merge branch 'main' into prop-initializer
pskelin Apr 30, 2024
91c07e9
chore: fix ts error
pskelin Apr 30, 2024
a76808c
chore: slider, rangeslider
Apr 29, 2024
4d74b44
chore: toast
Apr 30, 2024
75b6364
chore: switch, tab, tabcontainer, textarea
Apr 30, 2024
c147e93
chore: table
Apr 30, 2024
28a2df2
chore: option, select, radiobutton, panel, selectmenu
May 2, 2024
fb6e114
chore: jsdoc
May 2, 2024
f0ffeac
Merge remote-tracking branch 'origin/main' into prop-initializer
May 2, 2024
715c413
chore: popopver, popup, responsive popover and few fixes
May 2, 2024
c056553
chore: fix dom reference attribute handling for HTMLElement
pskelin May 9, 2024
2bdaf2a
Merge branch 'main' into prop-initializer
pskelin May 9, 2024
41f8795
chore: add token, tokenizer, year picker
pskelin May 9, 2024
40393e6
chore: convert timepickers
pskelin May 9, 2024
36c2340
chore: convert suggestions
pskelin May 9, 2024
eaf2f9a
chore: fix ts error
pskelin May 9, 2024
0914462
chore: ts fixes
pskelin May 9, 2024
22f9e69
Merge branch 'main' into prop-initializer
pskelin May 9, 2024
dd8d894
chore: fix ts errors
pskelin May 9, 2024
5b4d120
chore: fix overflow calculation the old way
pskelin May 9, 2024
4fbc6a5
chore: fix popup closing to be sync
pskelin May 10, 2024
2a39cf2
Merge branch 'main' into prop-initializer
pskelin May 10, 2024
0786787
Merge branch 'main' into prop-initializer
pskelin May 15, 2024
046d1c8
chore: fixes
pskelin May 15, 2024
b3d0f1b
chore: fix TS errors
pskelin May 15, 2024
0e5af4a
chore: fix tokenizer test
pskelin May 15, 2024
3330d59
chore: extract DOMReference converter
pskelin May 15, 2024
7298109
Merge branch 'main' into prop-initializer
pskelin May 15, 2024
237d66a
chore: fix tab container test
pskelin May 15, 2024
283a47c
chore: fix bad merge
pskelin May 15, 2024
60c9611
chore: convert more components
pskelin May 15, 2024
f18b538
chore: ts fix
pskelin May 15, 2024
f34b9ec
Merge branch 'main' into prop-initializer
pskelin May 20, 2024
9efac49
Merge branch 'main' into prop-initializer
pskelin May 21, 2024
d2756a4
chore: select tooltip optional
pskelin May 21, 2024
d578d40
chore: fix test pages
pskelin May 23, 2024
9b860b1
Merge branch 'main' into prop-initializer
pskelin May 23, 2024
3026f68
chore: fix types
pskelin May 23, 2024
f6824c1
chore: fix bad merge
pskelin May 23, 2024
42c335d
chore: fix test
pskelin May 23, 2024
61ad28b
chore: color palette fix
pskelin May 27, 2024
941e612
chore: make select option value optional
pskelin May 27, 2024
ba9b02d
Merge branch 'main' into prop-initializer
pskelin May 27, 2024
52e8418
Merge branch 'main' into prop-initializer
pskelin May 29, 2024
7b600ef
chore: select test page string usage
pskelin May 29, 2024
525f6cc
Merge branch 'main' into prop-initializer
pskelin May 30, 2024
81c58a1
Merge branch 'main' into prop-initializer
pskelin Jun 4, 2024
6742594
chore: cleanup old defaultValue code
pskelin Jun 4, 2024
7235a16
chore: more fixes
pskelin Jun 4, 2024
c4a006e
chore: fix base test
pskelin Jun 4, 2024
1dc8c14
chore: fix base tests
pskelin Jun 4, 2024
5f82139
Merge branch 'main' into prop-initializer
pskelin Jun 4, 2024
c94da37
Merge branch 'main' into prop-initializer
pskelin Jun 10, 2024
b3f492d
chore: apply attributes synchronously after first rendering
pskelin Jun 12, 2024
5fcf2ad
Merge branch 'main' into prop-initializer
pskelin Jun 12, 2024
68e6656
chore: adapt new table
pskelin Jun 12, 2024
5e57c69
chore: update sync attribute logic
pskelin Jun 12, 2024
0420bd8
Merge branch 'main' into prop-initializer
pskelin Jun 12, 2024
fa1559a
Merge branch 'main' into prop-initializer
pskelin Jun 13, 2024
814c9d2
chore: improve initialized property handling
pskelin Jun 13, 2024
b883b73
chore: comment
pskelin Jun 17, 2024
99e6764
Merge branch 'main' into prop-initializer
pskelin Jun 17, 2024
d81a874
chore: import order
pskelin Jun 17, 2024
66aa424
chore: rename decorator
pskelin Jun 17, 2024
9515e3b
chore: restore button page
pskelin Jun 17, 2024
08d5c84
Merge branch 'main' into prop-initializer
pskelin Jun 19, 2024
ea7c683
chore: fix merge errors
pskelin Jun 19, 2024
53ae24e
Merge branch 'main' into prop-initializer
pskelin Jun 20, 2024
1ad2576
chore: cleanup
pskelin Jun 20, 2024
20f09fb
Merge branch 'main' into prop-initializer
pskelin Jun 20, 2024
3e6261a
Merge branch 'main' into prop-initializer
pskelin Jun 20, 2024
ff61b37
chore: convert remaining !
pskelin Jun 20, 2024
1e5cd02
Merge branch 'main' into prop-initializer
pskelin Jun 21, 2024
b6288e8
chore: update docs
pskelin Jun 21, 2024
bc89b30
Merge branch 'main' into prop-initializer
pskelin Jun 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/ai/src/Button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,13 @@ class Button extends UI5Element {
* @public
*/
@property({ type: Boolean })
disabled!: boolean;
disabled = false;

@property()
icon!: string;
icon?: string;

@property()
endIcon!: string;
endIcon?: string;
}

Button.define();
Expand Down
27 changes: 13 additions & 14 deletions packages/ai/src/PromptInput.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ import slot from "@ui5/webcomponents-base/dist/decorators/slot.js";
import litRender from "@ui5/webcomponents-base/dist/renderer/LitRenderer.js";
import { getI18nBundle } from "@ui5/webcomponents-base/dist/i18nBundle.js";
import type I18nBundle from "@ui5/webcomponents-base/dist/i18nBundle.js";
import Integer from "@ui5/webcomponents-base/dist/types/Integer.js";
import ValueState from "@ui5/webcomponents-base/dist/types/ValueState.js";
import type ValueState from "@ui5/webcomponents-base/dist/types/ValueState.js";
import "@ui5/webcomponents-icons/dist/paper-plane.js";
import type { InputEventDetail } from "@ui5/webcomponents/dist/Input.js";
import Input from "@ui5/webcomponents/dist/Input.js";
Expand Down Expand Up @@ -89,27 +88,27 @@ class PromptInput extends UI5Element {
* @public
*/
@property()
value!: string;
value = "";

/**
* Defines a short hint intended to aid the user with data entry when the
* component has no value.
* @default ""
* @default undefined
* @since 2.0.0
* @public
*/
@property()
placeholder!: string;
placeholder?: string;

/**
* Defines the label of the input field.
*
* @default ""
* @default undefined
* @since 2.0.0
* @public
*/
@property()
label!: string;
label?: string;

/**
* Defines whether the clear icon of the input will be shown.
Expand All @@ -118,7 +117,7 @@ class PromptInput extends UI5Element {
* @since 2.0.0
*/
@property({ type: Boolean })
showClearIcon!: boolean;
showClearIcon = false;

/**
* Determines whether the characters exceeding the maximum allowed character count are visible
Expand All @@ -133,7 +132,7 @@ class PromptInput extends UI5Element {
* @since 2.0.0
*/
@property({ type: Boolean })
showExceededText!: boolean;
showExceededText = false;

/**
* Defines whether the component is in disabled state.
Expand All @@ -144,7 +143,7 @@ class PromptInput extends UI5Element {
* @since 2.0.0
*/
@property({ type: Boolean })
disabled!: boolean;
disabled = false;

/**
* Defines whether the component is read-only.
Expand All @@ -156,7 +155,7 @@ class PromptInput extends UI5Element {
* @since 2.0.0
*/
@property({ type: Boolean })
readonly!: boolean;
readonly = false;

/**
* Sets the maximum number of characters available in the input field.
Expand All @@ -165,7 +164,7 @@ class PromptInput extends UI5Element {
* @since 2.0.0
* @public
*/
@property({ validator: Integer })
@property({ type: Number })
maxlength?: number;

/**
Expand All @@ -174,8 +173,8 @@ class PromptInput extends UI5Element {
* @since 2.0.0
* @public
*/
@property({ type: ValueState, defaultValue: ValueState.None })
valueState!: `${ValueState}`;
@property()
valueState: `${ValueState}` = "None"

/**
* Defines the value state message that will be displayed as pop up under the component.
Expand Down
Loading
Loading