Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui5-breadcrumbs): rename property separator-style to separators #8600

Merged
merged 2 commits into from
Apr 3, 2024
Merged

refactor(ui5-breadcrumbs): rename property separator-style to separators #8600

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a5452e
refactor(ui5-breadcrumbs): rename property separator-style to separators
yanaminkova Apr 2, 2024
1754f5d
refactor(ui5-breadcrumbs): rename property separator-style to separators
yanaminkova Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/main/src/Breadcrumbs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ class Breadcrumbs extends UI5Element {
* @public
*/
@property({ type: BreadcrumbsSeparatorStyle, defaultValue: BreadcrumbsSeparatorStyle.Slash })
separatorStyle!: `${BreadcrumbsSeparatorStyle}`;
separators!: `${BreadcrumbsSeparatorStyle}`;

/**
* Holds the number of items in the overflow.
Expand Down
10 changes: 5 additions & 5 deletions packages/main/src/themes/Breadcrumbs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,22 +76,22 @@
}

/* separator styles */
:host([separator-style="DoubleSlash"]) .ui5-breadcrumbs-separator::after {
:host([separators="DoubleSlash"]) .ui5-breadcrumbs-separator::after {
content: "//";
}

:host([separator-style="BackSlash"]) .ui5-breadcrumbs-separator::after {
:host([separators="BackSlash"]) .ui5-breadcrumbs-separator::after {
content: "\\\\";
}

:host([separator-style="DoubleBackSlash"]) .ui5-breadcrumbs-separator::after {
:host([separators="DoubleBackSlash"]) .ui5-breadcrumbs-separator::after {
content: "\\\\\\\\";
}

:host([separator-style="GreaterThan"]) .ui5-breadcrumbs-separator::after {
:host([separators="GreaterThan"]) .ui5-breadcrumbs-separator::after {
content: ">";
}

:host([separator-style="DoubleGreaterThan"]) .ui5-breadcrumbs-separator::after {
:host([separators="DoubleGreaterThan"]) .ui5-breadcrumbs-separator::after {
content: ">>";
}
4 changes: 2 additions & 2 deletions packages/main/test/pages/Breadcrumbs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ <h2>Breadcrumbs with no current location</h2>
<ui5-breadcrumbs-item href="#">Link7</ui5-breadcrumbs-item>
</ui5-breadcrumbs>

<h2>Breadcrumbs with specific separator style</h2>
<h2>Breadcrumbs with specific separators</h2>
<ui5-select id="selectSeparator">
<ui5-option>Slash</ui5-option>
<ui5-option>BackSlash</ui5-option>
Expand Down Expand Up @@ -234,7 +234,7 @@ <h2>Breadcrumbs with hardcoded width</h2>

selectSeparator.addEventListener("ui5-change", function(e) {
let separator = e.detail.selectedOption.textContent;
breadcrumbs4.setAttribute("separator-style", separator);
breadcrumbs4.setAttribute("separators", separator);
});

</script>
Expand Down
24 changes: 12 additions & 12 deletions packages/main/test/samples/Breadcrumbs.sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,75 +47,75 @@ <h3>Breadcrumbs with no current page</h3>
<h3>Breadcrumbs with specific separator</h3>
<div class="snippet">
<div>
<ui5-breadcrumbs separator-style="Slash">
<ui5-breadcrumbs separators="Slash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="BackSlash">
<ui5-breadcrumbs separators="BackSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleBackSlash">
<ui5-breadcrumbs separators="DoubleBackSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleGreaterThan">
<ui5-breadcrumbs separators="DoubleGreaterThan">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleSlash">
<ui5-breadcrumbs separators="DoubleSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="GreaterThan">
<ui5-breadcrumbs separators="GreaterThan">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
</div>
<pre class="prettyprint lang-html"><xmp>
<ui5-breadcrumbs separator-style="Slash">
<ui5-breadcrumbs separators="Slash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
<ui5-breadcrumbs separator-style="BackSlash">
<ui5-breadcrumbs separators="BackSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
<ui5-breadcrumbs separator-style="DoubleBackSlash">
<ui5-breadcrumbs separators="DoubleBackSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
<ui5-breadcrumbs separator-style="DoubleGreaterThan">
<ui5-breadcrumbs separators="DoubleGreaterThan">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
<ui5-breadcrumbs separator-style="DoubleSlash">
<ui5-breadcrumbs separators="DoubleSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
<ui5-breadcrumbs separator-style="GreaterThan">
<ui5-breadcrumbs separators="GreaterThan">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page </ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
Expand Down
16 changes: 8 additions & 8 deletions packages/playground/_stories/main/Breadcrumbs/Breadcrumbs.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export default {
const Template: UI5StoryArgs<Breadcrumbs, StoryArgsSlots> = (args) =>
html`<ui5-breadcrumbs
design="${ifDefined(args.design)}"
separator-style="${ifDefined(args.separatorStyle)}"
separators="${ifDefined(args.separators)}"
>
${unsafeHTML(args.default)}
</ui5-breadcrumbs>`;
Expand All @@ -30,9 +30,9 @@ Basic.args = {
`,
};

export const SeparatorStyle: StoryFn = () => html`
export const Separators: StoryFn = () => html`
<div>
<ui5-breadcrumbs design ="NoCurrentPage" separator-style="Slash">
<ui5-breadcrumbs design ="NoCurrentPage" separators="Slash">
<ui5-breadcrumbs-item href="https://www.sap.com"
>Root Page
</ui5-breadcrumbs-item>
Expand All @@ -43,7 +43,7 @@ export const SeparatorStyle: StoryFn = () => html`
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="BackSlash">
<ui5-breadcrumbs separators="BackSlash">
<ui5-breadcrumbs-item href="https://www.sap.com"
>Root Page
</ui5-breadcrumbs-item>
Expand All @@ -54,7 +54,7 @@ export const SeparatorStyle: StoryFn = () => html`
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleBackSlash">
<ui5-breadcrumbs separators="DoubleBackSlash">
<ui5-breadcrumbs-item href="https://www.sap.com"
>Root Page
</ui5-breadcrumbs-item>
Expand All @@ -65,7 +65,7 @@ export const SeparatorStyle: StoryFn = () => html`
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleGreaterThan">
<ui5-breadcrumbs separators="DoubleGreaterThan">
<ui5-breadcrumbs-item href="https://www.sap.com"
>Root Page
</ui5-breadcrumbs-item>
Expand All @@ -76,7 +76,7 @@ export const SeparatorStyle: StoryFn = () => html`
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleSlash">
<ui5-breadcrumbs separators="DoubleSlash">
<ui5-breadcrumbs-item href="https://www.sap.com"
>Root Page
</ui5-breadcrumbs-item>
Expand All @@ -87,7 +87,7 @@ export const SeparatorStyle: StoryFn = () => html`
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="GreaterThan">
<ui5-breadcrumbs separators="GreaterThan">
<ui5-breadcrumbs-item href="https://www.sap.com"
>Root Page
</ui5-breadcrumbs-item>
Expand Down
10 changes: 5 additions & 5 deletions packages/website/docs/_samples/main/Breadcrumbs/BreadcrumbsStyles/sample.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,39 +12,39 @@
<!-- playground-fold-end -->

<div>
<ui5-breadcrumbs separator-style="BackSlash">
<ui5-breadcrumbs separators="BackSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page
</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleBackSlash">
<ui5-breadcrumbs separators="DoubleBackSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page
</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleGreaterThan">
<ui5-breadcrumbs separators="DoubleGreaterThan">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page
</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="DoubleSlash">
<ui5-breadcrumbs separators="DoubleSlash">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page
</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item>Current Page</ui5-breadcrumbs-item>
</ui5-breadcrumbs>
</div>
<div>
<ui5-breadcrumbs separator-style="GreaterThan">
<ui5-breadcrumbs separators="GreaterThan">
<ui5-breadcrumbs-item href="https://www.sap.com">Root Page
</ui5-breadcrumbs-item>
<ui5-breadcrumbs-item href="https://www.sap.com">Parent Page</ui5-breadcrumbs-item>
Expand Down