Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create package bugs #5517

Merged
merged 2 commits into from
Jul 18, 2022
Merged

fix: create package bugs #5517

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8fc8b1
fix: create package bugs
vladitasev Jul 18, 2022
a407b49
docs: add JSDoc for the demo component
vladitasev Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: create package bugs
  • Loading branch information
@vladitasev
vladitasev committed Jul 18, 2022
commit b8fc8b12245c08dc481e2ce616c34a2b31e75b69
8 changes: 5 additions & 3 deletions packages/create-package/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ const mkdirp = require("mkdirp");
const prompts = require("prompts");
const parser = require("npm-config-user-agent-parser");

const version = JSON.parse(fs.readFileSync(path.join(__dirname, "package.json"))).version;

// from where all the files will be copied
const TEMPLATE_DIR = path.join(`${__dirname}`, `template/`);

Expand Down Expand Up @@ -129,11 +131,11 @@ const createWebcomponentsPackage = async () => {
"./*": "./dist/*",
},
"dependencies": {
"@ui5/webcomponents-base": "1.1.1",
"@ui5/webcomponents-theming": "1.1.1",
"@ui5/webcomponents-base": version,
"@ui5/webcomponents-theming": version,
},
"devDependencies": {
"@ui5/webcomponents-tools": "1.1.1",
"@ui5/webcomponents-tools": version,
"chromedriver": "*",
},
};
Expand Down
2 changes: 1 addition & 1 deletion packages/create-package/template/test/pages/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
}
</script>

<script src="../../resources/bundle.esm.js" type="module"></script>
<script src="../../bundle.esm.js" type="module"></script>

<style>
code { color: blue; font-size: small; }
Expand Down