Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not append " | " to OneLogin::RubySaml::Response#status_code unnecessarily #585

Merged
merged 1 commit into from
May 10, 2021
Merged

Do not append " | " to OneLogin::RubySaml::Response#status_code unnecessarily #585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions lib/onelogin/ruby-saml/response.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,10 @@ def status_code
statuses = nodes.collect do |inner_node|
inner_node.attributes["Value"]
end
extra_code = statuses.join(" | ")
if extra_code
code = "#{code} | #{extra_code}"
end

code = [code, statuses].flatten.join(" | ")
end

code
end
end
Expand Down
10 changes: 10 additions & 0 deletions test/response_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1635,6 +1635,16 @@ def generate_audience_error(expected, actual)
end

end

describe "#status_code" do
it 'urn:oasis:names:tc:SAML:2.0:status:Responder' do
assert_equal response_statuscode_responder.status_code, 'urn:oasis:names:tc:SAML:2.0:status:Responder'
end

it 'urn:oasis:names:tc:SAML:2.0:status:Requester and urn:oasis:names:tc:SAML:2.0:status:UnsupportedBinding' do
assert_equal response_double_statuscode.status_code, 'urn:oasis:names:tc:SAML:2.0:status:Requester | urn:oasis:names:tc:SAML:2.0:status:UnsupportedBinding'
end
end
describe "test qualified name id in attributes" do

it "parsed the nameid" do
Expand Down