Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use subtle v2 #13

Merged
merged 1 commit into from
Dec 27, 2018
Merged

Use subtle v2 #13

merged 1 commit into from
Dec 27, 2018

Conversation

hdevalence
Copy link
Contributor

Hi, we released version 2 of subtle (context: RustCrypto/traits#33 (comment) ).

As far as I can tell, subtle is only used for ConstantTimeEq, which is only used internally, so this dependency upgrade will not be a semver breaking change.

@newpavlov
Copy link
Member

Yes, in this case we can update subtle without any problems. Though before merging I probably should understand why thumbv7em-none-eabi CI test fails. (at first glance looks like a nightly breakage)

@newpavlov newpavlov merged commit ab76944 into RustCrypto:master Dec 27, 2018
@tarcieri tarcieri mentioned this pull request Jun 10, 2020
Merged
@newpavlov newpavlov mentioned this pull request Jun 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdevalence @newpavlov