Skip to content

Commit

Permalink
♻️ Refactor FastAPI Experts to use only discussions now that question…
Browse files Browse the repository at this point in the history
…s are migrated (fastapi#9165)
  • Loading branch information
tiangolo authored and RobinSiep committed Mar 1, 2023
1 parent 3dbc4f5 commit 1ae5623
Showing 1 changed file with 14 additions and 10 deletions.
24 changes: 14 additions & 10 deletions .github/actions/people/app/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -496,21 +496,25 @@ def get_discussions_experts(settings: Settings):


def get_experts(settings: Settings):
(
issues_commentors,
issues_last_month_commentors,
issues_authors,
) = get_issues_experts(settings=settings)
# Migrated to only use GitHub Discussions
# (
# issues_commentors,
# issues_last_month_commentors,
# issues_authors,
# ) = get_issues_experts(settings=settings)
(
discussions_commentors,
discussions_last_month_commentors,
discussions_authors,
) = get_discussions_experts(settings=settings)
commentors = issues_commentors + discussions_commentors
last_month_commentors = (
issues_last_month_commentors + discussions_last_month_commentors
)
authors = {**issues_authors, **discussions_authors}
# commentors = issues_commentors + discussions_commentors
commentors = discussions_commentors
# last_month_commentors = (
# issues_last_month_commentors + discussions_last_month_commentors
# )
last_month_commentors = discussions_last_month_commentors
# authors = {**issues_authors, **discussions_authors}
authors = {**discussions_authors}
return commentors, last_month_commentors, authors


Expand Down

0 comments on commit 1ae5623

Please sign in to comment.