Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround to allow using proxy URL in Local.xcconfig #4810

Merged
merged 2 commits into from
Feb 24, 2025

Conversation

ajpallares
Copy link
Member

@ajpallares ajpallares commented Feb 21, 2025

Implements a workaround to allow specifying the proxy URL for the PaywallsTester app in the Local.xcconfig file (see also #4795)

Motivation

Because two slashes // are interpreted as comments in xcconfig files, there's no clean way to specify a URL with the scheme in such file.

Description

With this PR we define two different variables for the proxyURL scheme and host.
The idea is that the proxy URL must now be specified with

REVENUECAT_PROXY_URL_SCHEME = http
REVENUECAT_PROXY_URL_HOST = localhost:9000

@ajpallares ajpallares requested review from facumenzella and a team February 21, 2025 16:33
Copy link
Contributor

@vegaro vegaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense

@ajpallares ajpallares merged commit f208ea1 into main Feb 24, 2025
9 of 10 checks passed
@ajpallares ajpallares deleted the proxy-url-in-local-config branch February 24, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants