Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docstrings to tf classes #5401

Merged
merged 4 commits into from
Mar 11, 2020
Merged

add docstrings to tf classes #5401

merged 4 commits into from
Mar 11, 2020

Conversation

Ghostvv
Copy link
Contributor

@Ghostvv Ghostvv commented Mar 10, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@Ghostvv Ghostvv requested a review from tabergma March 10, 2020 14:52
Copy link
Contributor

@tabergma tabergma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding the doc strings 👍

Left a few comment.s

@Ghostvv
Copy link
Contributor Author

Ghostvv commented Mar 10, 2020

how the coverage managed to decrease?

@tabergma
Copy link
Contributor

Not sure how the check is working but could be simple because more lines were added to the code. So number of lines covered by tests divided by total number of lines decreased. But not sure about that.

@Ghostvv Ghostvv merged commit 35b8ed5 into master Mar 11, 2020
@Ghostvv Ghostvv deleted the tf-docstrings branch March 11, 2020 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants