Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docstrings and naming #5319

Closed
3 tasks done
tabergma opened this issue Feb 26, 2020 · 0 comments
Closed
3 tasks done

Docstrings and naming #5319

tabergma opened this issue Feb 26, 2020 · 0 comments
Assignees
@Ghostvv @dakshvar22
Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.

Comments

@tabergma
Copy link
Contributor

tabergma commented Feb 26, 2020 •
edited by dakshvar22
Loading

Clean up/Tackle remaining open tasks from #5266

  • make sure to name things properly, don't use abbreviations (especially in the utils.tensorflow package) - Vova
  • Add docstrings and types to all methods, classes in utils.tensorflow package (Vova)
  • Add docstrings and types to all methods in nlu.utils.hugging_face (Daksh)
@tabergma tabergma added type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style. area:rasa-oss 🎡 Anything related to the open source Rasa framework labels Feb 26, 2020
@tabergma tabergma mentioned this issue Feb 26, 2020
Merged
4 tasks
@tabergma tabergma assigned Ghostvv, tabergma and dakshvar22 and unassigned tabergma Feb 28, 2020
@tabergma tabergma changed the title Clean up after TF 2 and new NLU architecture Docstrings and naming Mar 2, 2020
@dakshvar22 dakshvar22 mentioned this issue Mar 10, 2020
Merged
4 tasks
@Ghostvv Ghostvv mentioned this issue Mar 10, 2020
Merged
4 tasks
@Ghostvv Ghostvv closed this as completed Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ghostvv Ghostvv

@dakshvar22 dakshvar22

Labels
area:rasa-oss 🎡 Anything related to the open source Rasa framework type:maintenance 🔧 Improvements to tooling, testing, deployments, infrastructure, code style.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Ghostvv @tabergma @dakshvar22