Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature trigger class definition #90
Feature trigger class definition #90
Changes from all commits
8c2380f
e27dc35
81bcbd8
2a590c1
910c9d3
12f093f
623f1ec
b20ff38
38a92a7
b86859d
553e306
8e39ee1
96cb272
fbd09f3
b5460e3
c0fb63d
6e0fbb6
ff04a7b
a1a531c
e5528ee
1010cb6
d7749ea
6419fe9
ddebb46
a648fa5
e7000d3
204a58f
b286bc0
cd88006
7de0456
7a96926
3f87003
72edea2
3cf874e
b6c4240
8aa894c
a7d1b21
87e8eb2
2135840
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it hard to understand what this is and what is intended to be used for. Is the list a general description of a trigger on a high level? If this is the case is there an example of an intended use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to have some opinions on this. I intended it to store the ISO parameters (e.g. ACCELERATION, GREATER_THAN, VALUE) for parsing into an operation mode for the trigger. Perhaps it is not interesting to conform to ISO here? Currently, it is used by e.g. BooleanTrigger to select between flank triggering and high/low etc. . But eventually we will read this from a file...