Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature object control start ACCM #245

Merged
merged 4 commits into from
May 27, 2020
Merged

Conversation

LukasWikander
Copy link
Collaborator

Builds on #244 . Added a list of test scenario commands which are to be sent on EXAC. (currently only STRT)

Copy link
Member

@konglobemeralt konglobemeralt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as with distance trigger, just checking to find out if this reflects the code used during the demo or if some additional changes should be added?

@LukasWikander
Copy link
Collaborator Author

Same as with distance trigger, just checking to find out if this reflects the code used during the demo or if some additional changes should be added?

I've split the distance trigger work until the demo into several steps and this is step 2 I believe. The branch reflecting what was used in the demo is only the demo branch :) since none of the feature branches leading up to the "full" distance trigger implementation contain e.g. the back to start function. And the back to start feature branch does not contain the distance triggers.

@konglobemeralt
Copy link
Member

Really shrank the size of this pr with the other merges ;)

@konglobemeralt konglobemeralt self-requested a review May 27, 2020 10:34
@LukasWikander LukasWikander merged commit c7be37e into dev May 27, 2020
@LukasWikander LukasWikander deleted the feature_objectControlStartACCM branch May 27, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants