Skip to content

refactor(adapters): modify build scripts to include additional vite b… #7504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Apr 9, 2025

…uild step

The build scripts in all adapters' package.json files were updated to include an additional vite build step before the existing build command. This ensures a more robust build process by performing a standard build before the adapter-specific build.

What is it?

fixes #7479

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

…uild step

The build scripts in all adapters' package.json files were updated to include an additional `vite build` step before the existing build command. This ensures a more robust build process by performing a standard build before the adapter-specific build.
@JerryWu1234 JerryWu1234 requested a review from a team as a code owner April 9, 2025 08:07
Copy link

changeset-bot bot commented Apr 9, 2025

🦋 Changeset detected

Latest commit: 0866fc4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Major
@builder.io/qwik Major
eslint-plugin-qwik Major
create-qwik Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Apr 9, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@7504
npm i https://pkg.pr.new/@builder.io/qwik-city@7504
npm i https://pkg.pr.new/eslint-plugin-qwik@7504
npm i https://pkg.pr.new/create-qwik@7504

commit: bebc3f7

Copy link
Contributor

github-actions bot commented Apr 9, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview bebc3f7

@wmertens
Copy link
Member

The problem is that when you run build.server, you're supposed to know what you're doing. Otherwise, you would just run build.

By doing the client build twice you're making things slower for everyone.

So I cannot accept this PR, but if it is really necessary to make sure client is up to date, perhaps a command can be added to qwik-cli to check that that is so and print a warning.

For example qwik check-client => no output or client build is missing or client build is older than the source code.

@wmertens wmertens closed this Apr 11, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Qwik Development Apr 11, 2025
@JerryWu1234
Copy link
Contributor Author

JerryWu1234 commented Apr 12, 2025

The problem is that when you run build.server, you're supposed to know what you're doing. Otherwise, you would just run build.

By doing the client build twice you're making things slower for everyone.

So I cannot accept this PR, but if it is really necessary to make sure client is up to date, perhaps a command can be added to qwik-cli to check that that is so and print a warning.

For example qwik check-client => no output or client build is missing or client build is older than the source code.

The problem is that when you run build.server, you're supposed to know what you're doing. Otherwise, you would just run build.

By doing the client build twice you're making things slower for everyone.

So I cannot accept this PR, but if it is really necessary to make sure client is up to date, perhaps a command can be added to qwik-cli to check that that is so and print a warning.

For example qwik check-client => no output or client build is missing or client build is older than the source code.

@wmertens
I have different ideas about this.
Could we check if the use has a directory named disk after running qwik add?
and we throw a warning or help user to run build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[🐞] server build should detect when client build is missing or out of date
2 participants