Skip to content

Broken links fixed and runned tests to conform it #7451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 26, 2025

Conversation

iitzIrFan
Copy link
Contributor

@iitzIrFan iitzIrFan commented Mar 24, 2025

What is it?

Resolves :- #6802

  • Bug
  • Docs / tests / types / typos

Description

Had fixed the broken links and runned tests to test if they are working as expected.

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@iitzIrFan iitzIrFan requested a review from a team as a code owner March 24, 2025 19:29
Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: b5dbca5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 24, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 1eef501

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! But you can remove the package.json change.

Could this be run as part of CI? In the docs build step?

@iitzIrFan
Copy link
Contributor Author

This is great! But you can remove the package.json change.

Could this be run as part of CI? In the docs build step?

@wmertens I don't know this ! Only have to remove package.json changes ?

@wmertens
Copy link
Member

Yes just remove the changes

@iitzIrFan
Copy link
Contributor Author

@wmertens I had made changes and this looks good to me check and update

@iitzIrFan iitzIrFan requested a review from wmertens April 26, 2025 16:41
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wmertens wmertens merged commit 38ae32d into QwikDev:main Apr 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants