Check for Event object with getConstructorName during worker serialization
#328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
erxclau
changed the title
Event object with Symbol.toStringTagEvent object with Symbol.toStringTag during worker serialization
erxclau
changed the title
Event object with Symbol.toStringTag during worker serializationEvent object with getConstructorName during worker serialization
|
Great fix, thanks! |
1 task
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #284 and also fixes #313 and also fixes #178.
A previous PR (#269) tried checking if the object to serialize for the worker was an Event using
obj instanceof Event. However, this was failing for some reason. I changed the check to usegetConstructorName.I did some brief testing on a Next app using the build output and the deprecation warning doesn't appear anymore.