Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Flow and FlowRun CRUD methods in client #16581

Merged
merged 18 commits into from
Jan 3, 2025
Merged

Conversation

aaazzam
Copy link
Collaborator

@aaazzam aaazzam commented Jan 3, 2025

Related to #16472, this PR continues the optimization pattern established for Artifacts. Like the previous PRs, it:

  • Refactors the client's Flow and FlowRun CRUD methods into a standalone module
  • Uses ForwardRefs for heavy imports, moving them into the call itself

Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #16581 will not alter performance

Comparing refactor-flows-client (45c22fb) with main (d398bb1)

Summary

✅ 3 untouched benchmarks

@aaazzam aaazzam enabled auto-merge (squash) January 3, 2025 05:04
@aaazzam aaazzam requested a review from desertaxle January 3, 2025 16:06
@aaazzam aaazzam requested a review from desertaxle January 3, 2025 16:38
Copy link
Member

@desertaxle desertaxle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaazzam aaazzam merged commit ee519b2 into main Jan 3, 2025
39 checks passed
@aaazzam aaazzam deleted the refactor-flows-client branch January 3, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants