Undo changes to superset/databases/api.py

PlaidCloud · Apr 10, 2024 · e345da0 · e345da0
1 parent c42c6bc
commit e345da0
Showing 1 changed file with 0 additions and 10 deletions.
diff --git a/superset/databases/api.py b/superset/databases/api.py
@@ -150,7 +150,6 @@ class DatabaseRestApi(BaseSupersetModelRestApi):
         "impersonate_user",
         "is_managed_externally",
         "engine_information",
-        "sqlalchemy_uri"
     ]
     list_columns = [
         "allow_file_upload",
@@ -177,7 +176,6 @@ class DatabaseRestApi(BaseSupersetModelRestApi):
         "uuid",
         "disable_data_preview",
         "engine_information",
-        "sqlalchemy_uri"
     ]
     add_columns = [
         "database_name",
@@ -335,7 +333,6 @@ def get(self, pk: int, **kwargs: Any) -> Response:
                 return payload
             return data
         except SupersetException as ex:
-            logger.exception(ex.message)
             return self.response(ex.status, message=ex.message)
 
     @expose("/", methods=("POST",))
@@ -384,7 +381,6 @@ def post(self) -> FlaskResponse:
             item = self.add_model_schema.load(request.json)
         # This validates custom Schema with custom validations
         except ValidationError as error:
-            logger.exception(error.message)
             return self.response_400(message=error.messages)
         try:
             new_model = CreateDatabaseCommand(item).run()
@@ -406,14 +402,10 @@ def post(self) -> FlaskResponse:
 
             return self.response(201, id=new_model.id, result=item)
         except DatabaseInvalidError as ex:
-            # logger.exception(ex.message)
-            logger.exception(f"database_name: {item['database_name']}\nuuid: {item['uuid']}\ndb_connection_failed.{ex.__class__.__name__}.{'.'.join(ex.get_list_classnames())}")
             return self.response_422(message=ex.normalized_messages())
         except DatabaseConnectionFailedError as ex:
-            logger.exception(ex.message)
             return self.response_422(message=str(ex))
         except SupersetErrorsException as ex:
-            logger.exception(ex.message)
             return json_errors_response(errors=ex.errors, status=ex.status)
         except DatabaseCreateFailedError as ex:
             logger.error(
@@ -424,10 +416,8 @@ def post(self) -> FlaskResponse:
             )
             return self.response_422(message=str(ex))
         except SSHTunnelingNotEnabledError as ex:
-            logger.exception(ex.message)
             return self.response_400(message=str(ex))
         except SupersetException as ex:
-            logger.exception(ex.message)
             return self.response(ex.status, message=ex.message)
 
     @expose("/<int:pk>", methods=("PUT",))