-
Notifications
You must be signed in to change notification settings - Fork 11.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling in ERC20 and ERC721 #1702
Conversation
Hello @princesinha19, thank you for contributing! We've received multiple requests for this (ever since #888) and will be working on it shortly: see my related comment here for more relevant information. |
okay cools @nventuro |
Please see this post in our forum for discussion regarding revert reasons, and share your thoughts! |
@princesinha19 I opened #1709 with some guidelines regarding message format, among other things, including some examples. Could you review it and update your PR accordingly? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your initiative @princesinha19! I left some comments guiding some of the messages, along with a couple questions. Please review all reason strings according to these. Also, don't forget to append a prefix with the contract name (e.g. 'ERC20: ').
Thanks again!
thanks, @nventuro for your suggestions. |
@princesinha19 to keep things organized, I merged this PR into #1704 (see this commit), while doing some slight modifications to a couple messages, so I'm closing this PR now in favor of the other one. Thank you very much for your contribution! |
Okay, no problem. @nventuro |
I did some error handling in ERC20 and ERC721. In every require, I added some messages so that developer or end user can easily understand what's wrong.
Fixes #1701