Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:extras_requirements #95

Merged
merged 2 commits into from
Sep 11, 2024
Merged

feat:extras_requirements #95

merged 2 commits into from
Sep 11, 2024

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Sep 11, 2024

default plugins that should be bundled in a "full" install

Summary by CodeRabbit

  • New Features

    • Introduced new plugins for enhanced functionality, including support for YouTube, M3U playlists, RSS feeds, file handling, and news integration.
  • Improvements

    • Updated version constraints for existing plugins to ensure better compatibility and stability within the application.
    • Streamlined the installation process by consolidating dependencies, improving efficiency in the build workflow.

default plugins that should be bundled in a "full" install
Copy link
Contributor

coderabbitai bot commented Sep 11, 2024

Walkthrough

The pull request introduces modifications to the requirements/extras.txt file, focusing on version constraints for existing plugins and adding new plugins for the Open Conversation Platform (OCP). Additionally, changes to the GitHub Actions workflow streamline the installation process by removing unnecessary dependencies and consolidating installation commands. These updates aim to enhance dependency management and simplify the build and testing workflows.

Changes

Files Change Summary
requirements/extras.txt Modified version constraints for ovos-tts-plugin-server and ovos_audio_plugin_simple. Added new entries for OCP plugins with specific version requirements.
.github/workflows/build_tests.yml Removed libfann-dev from system dependencies, eliminated a step for numpy and tflite_runtime, and simplified the installation command to [extras].

Poem

In the garden of code, we hop and play,
With plugins anew, brightening the day.
Version ranges set, our paths align,
Stability blooms, oh how we shine!
A dance of dependencies, in harmony we sing,
Hopping through changes, let the joy spring! 🐰✨


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1930e50 and 34df0eb.

Files selected for processing (1)
  • .github/workflows/build_tests.yml (1 hunks)
Additional comments not posted (2)
.github/workflows/build_tests.yml (2)

23-23: LGTM, but verify the build process.

The changes are approved.

However, ensure that the build process works correctly without the libfann-dev package.

Run the following script to verify the build process:


32-32: LGTM, but verify the installation process.

The changes are approved.

However, ensure that the installation process works correctly with the simplified .[extras] option.

Run the following script to verify the installation process:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added feature and removed feature labels Sep 11, 2024
default plugins that should be bundled in a "full" install
@github-actions github-actions bot added feature and removed feature labels Sep 11, 2024
@JarbasAl JarbasAl merged commit 242cec9 into dev Sep 11, 2024
6 checks passed
@JarbasAl JarbasAl deleted the extras_requirements branch September 11, 2024 16:48
This was referenced Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant